Skip to content

feat: updated Schemas and Intents#2552

Merged
JoeCap08055 merged 46 commits intomainfrom
feat/schemas-permissions-development
Dec 9, 2025
Merged

feat: updated Schemas and Intents#2552
JoeCap08055 merged 46 commits intomainfrom
feat/schemas-permissions-development

Conversation

@JoeCap08055
Copy link
Copy Markdown
Collaborator

@JoeCap08055 JoeCap08055 commented Aug 13, 2025

Goal

The goal of this PR is to implement the design described here

Tracking epic: #2550

Checklist

  • Updated Pallet Readme?
  • Updated js/api-augment for Custom RPC APIs?
  • Design doc(s) updated?
  • Unit Tests added?
  • e2e Tests added?
  • Benchmarks added?
  • Spec version incremented?

@JoeCap08055 JoeCap08055 requested a review from wilwade as a code owner August 15, 2025 16:25
# Goal
The goal of this PR is to implement *only* the *types* and *pallet
storage* for the following new on-chain entities:
* Intents
* IntentGroups

Closes #2561

**NOTE:** No tests or benchmarks added in this PR, as it only contains
types and storage, no executable runtime code (coming in a separate PR)

# Checklist
- [x] Updated Pallet Readme?
- [ ] Updated js/api-augment for Custom RPC APIs?
- [x] Design doc(s) updated?
- [ ] Unit Tests added?
- [ ] e2e Tests added?
- [ ] Benchmarks added?
- [ ] Spec version incremented?
# Conflicts:
#	runtime/frequency/src/lib.rs
…ntGroup) (#2563)

# Description
This PR implments type, storage, and runtime RPCs for mapping fully
qualified names of the form `<protocol>.<descriptor>` to Intents or
IntentGroups.

Additional tests & support will be the subject of an upcoming PR; this
is only merging to a feature branch.

Closes #2562 

# Discussion

- <!-- List discussion items -->

# Checklist
- [ ] Updated Pallet Readme?
- [ ] Updated js/api-augment for Custom RPC APIs?
- [ ] Design doc(s) updated?
- [ ] Unit Tests added?
- [ ] e2e Tests added?
- [ ] Benchmarks added?
- [ ] Spec version incremented?
@JoeCap08055 JoeCap08055 force-pushed the feat/schemas-permissions-development branch from b91436b to 6307cc1 Compare August 20, 2025 15:29
@JoeCap08055 JoeCap08055 marked this pull request as draft August 20, 2025 15:30
@codecov
Copy link
Copy Markdown

codecov bot commented Aug 20, 2025

Codecov Report

❌ Patch coverage is 61.40758% with 499 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
pallets/stateful-storage/src/lib.rs 36.18% 127 Missing ⚠️
pallets/schemas/src/migration/v5.rs 0.00% 94 Missing ⚠️
pallets/schemas/src/lib.rs 77.80% 89 Missing ⚠️
pallets/stateful-storage/src/migration/v1/types.rs 56.86% 44 Missing ⚠️
pallets/messages/src/lib.rs 34.84% 43 Missing ⚠️
pallets/messages/src/types.rs 64.47% 27 Missing ⚠️
common/primitives/src/stateful_storage.rs 32.14% 19 Missing ⚠️
common/primitives/src/schema.rs 37.03% 17 Missing ⚠️
common/primitives/src/messages.rs 0.00% 11 Missing ⚠️
pallets/schemas/src/types.rs 56.52% 10 Missing ⚠️
... and 3 more
Files with missing lines Coverage Δ
common/primitives/src/cid.rs 100.00% <100.00%> (ø)
pallets/messages/src/rpc/src/lib.rs 92.00% <100.00%> (-3.84%) ⬇️
pallets/msa/src/rpc/src/lib.rs 67.28% <100.00%> (ø)
pallets/msa/src/types.rs 100.00% <100.00%> (ø)
pallets/schemas/src/rpc/src/lib.rs 100.00% <ø> (+5.71%) ⬆️
pallets/stateful-storage/src/migration/v2.rs 92.44% <ø> (ø)
pallets/stateful-storage/src/rpc/src/lib.rs 86.48% <ø> (ø)
...allets/stateful-storage/src/stateful_child_tree.rs 74.25% <ø> (+3.20%) ⬆️
pallets/stateful-storage/src/test_common.rs 100.00% <ø> (ø)
pallets/stateful-storage/src/types.rs 78.66% <ø> (-14.44%) ⬇️
... and 13 more
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@github-actions github-actions bot added metadata-changed Metadata has changed since the latest full release metadata-version-not-incremented Metadata has changed since the latest full release, but the version has not been incremented labels Aug 20, 2025
# Goal
The goal of this PR is to implement the extrinsics, RPCs and unit tests
for Intents and IntentGroups.

Closes #2564 

# Discussion

- <!-- List discussion items -->

# Checklist
- [x] Updated Pallet Readme?
- [ ] Updated js/api-augment for Custom RPC APIs?
- [ ] Design doc(s) updated?
- [x] Unit Tests added?
- [ ] e2e Tests added?
- [x] Benchmarks added?
- [ ] Spec version incremented?
@github-actions github-actions bot added metadata-changed Metadata has changed since the latest full release metadata-version-not-incremented Metadata has changed since the latest full release, but the version has not been incremented and removed metadata-changed Metadata has changed since the latest full release metadata-version-not-incremented Metadata has changed since the latest full release, but the version has not been incremented labels Aug 29, 2025
# Goal
The goal of this PR is to update the types, extrinsics, and runtime APIs
for the Schemas pallet to conform to the new design

Closes #2580 

# Checklist
- [ ] Updated Pallet Readme?
- [x] Updated js/api-augment for Custom RPC APIs?
- [ ] Design doc(s) updated?
- [ ] Unit Tests added?
- [ ] e2e Tests added?
- [x] Benchmarks added?
- [ ] Spec version incremented?

---------

Co-authored-by: Shannon Wells <shannonwells@users.noreply.github.com>
Co-authored-by: Aramik <aramikm@gmail.com>
# Goal
The goal of this PR is to migrate the `messages` pallet to add
`schema_id` to message storage, and use `intent_id` as the index
instead.

Existing index values do not need to be changed, as the `schemas` pallet
migration ensures that the chain is seeded with Intent IDs that match
existing Schema IDs

Related to #2581 

# Checklist
- [ ] Updated Pallet Readme?
- [ ] Updated js/api-augment for Custom RPC APIs?
- [ ] Design doc(s) updated?
- [x] Unit Tests added?
- [ ] e2e Tests added?
- [x] Benchmarks added?
- [ ] Spec version incremented?
# Goal
The goal of this PR is to implement the changes necessary to update the
`stateful-storage` and `msa` pallets to use the new Schemas and Intents
framework. This includes a migration of child trie storage in the
`stateful-storage` pallet.

Closes #2581
@github-actions github-actions bot removed metadata-changed Metadata has changed since the latest full release metadata-version-not-incremented Metadata has changed since the latest full release, but the version has not been incremented labels Oct 31, 2025
@JoeCap08055 JoeCap08055 marked this pull request as ready for review October 31, 2025 16:08
@github-actions github-actions bot added metadata-changed Metadata has changed since the latest full release and removed metadata-changed Metadata has changed since the latest full release labels Nov 19, 2025
@github-actions github-actions bot added metadata-changed Metadata has changed since the latest full release and removed metadata-changed Metadata has changed since the latest full release labels Nov 19, 2025
@github-actions github-actions bot added metadata-changed Metadata has changed since the latest full release and removed metadata-changed Metadata has changed since the latest full release labels Nov 19, 2025
Copy link
Copy Markdown
Collaborator

@shannonwells shannonwells left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nothing blocking from me!

@github-actions github-actions bot added metadata-changed Metadata has changed since the latest full release and removed metadata-changed Metadata has changed since the latest full release labels Nov 20, 2025
@github-actions github-actions bot added metadata-changed Metadata has changed since the latest full release and removed metadata-changed Metadata has changed since the latest full release labels Nov 20, 2025
@github-actions github-actions bot added metadata-changed Metadata has changed since the latest full release and removed metadata-changed Metadata has changed since the latest full release labels Nov 20, 2025
@JoeCap08055 JoeCap08055 requested a review from aramikm November 24, 2025 19:21
Copy link
Copy Markdown
Collaborator

@aramikm aramikm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Tremendous effort and great feature to add.

Copy link
Copy Markdown
Collaborator

@enddynayn enddynayn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great efforts!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

change/breaking Breaking change to document in this PR change/major Major Changes in this PR change/storage-migration PR has a Storage Migration enhancement New feature or request metadata-changed Metadata has changed since the latest full release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants