Feat/intents extrinsics and rpcs#2570
Merged
JoeCap08055 merged 21 commits intofeat/schemas-permissions-developmentfrom Aug 29, 2025
Merged
Feat/intents extrinsics and rpcs#2570JoeCap08055 merged 21 commits intofeat/schemas-permissions-developmentfrom
JoeCap08055 merged 21 commits intofeat/schemas-permissions-developmentfrom
Conversation
# Goal The goal of this PR is to implement *only* the *types* and *pallet storage* for the following new on-chain entities: * Intents * IntentGroups Closes #2561 **NOTE:** No tests or benchmarks added in this PR, as it only contains types and storage, no executable runtime code (coming in a separate PR) # Checklist - [x] Updated Pallet Readme? - [ ] Updated js/api-augment for Custom RPC APIs? - [x] Design doc(s) updated? - [ ] Unit Tests added? - [ ] e2e Tests added? - [ ] Benchmarks added? - [ ] Spec version incremented? # Conflicts: # pallets/schemas/src/lib.rs # pallets/schemas/src/tests/other_tests.rs # pallets/schemas/src/types.rs # runtime/frequency/src/lib.rs
Codecov Report❌ Patch coverage is
🚀 New features to boost your workflow:
|
aramikm
approved these changes
Aug 28, 2025
Collaborator
aramikm
left a comment
There was a problem hiding this comment.
Overall looks good.
Approving to unblock but there are some comments that needs attention before merging
saraswatpuneet
approved these changes
Aug 29, 2025
Collaborator
saraswatpuneet
left a comment
There was a problem hiding this comment.
looks good, one question around update path
7b6fdcf
into
feat/schemas-permissions-development
31 of 32 checks passed
| pub intent_group_id: u16, | ||
| /// The list of currently supported IntentIds for this IntentGroup | ||
| pub intent_ids: Option<Vec<IntentId>>, | ||
| pub intent_ids: Vec<IntentId>, |
Collaborator
There was a problem hiding this comment.
Was this never meant to be an option?
Collaborator
Author
There was a problem hiding this comment.
Not sure what this will eventually look like... an upcoming PR in the epic will revisit these runtime APIs and responses, anyway
JoeCap08055
commented
Aug 29, 2025
| } | ||
|
|
||
| /// Adds a given schema to storage. The schema in question must be of length | ||
| /// Adds a given schema to storage. (testnet) |
Collaborator
Author
There was a problem hiding this comment.
Following the existing pattern in the pallet, it exists but the call is filtered in the Runtime on Mainnet. Not sure why it's done that way vs a feature flag; that decision predates me.
| // check that doesn't start with a decimal digit. | ||
| // (This also handles the case where the value is all numeric, because it would also | ||
| // start with a decimal digit.) | ||
| ensure!(namespace[0].is_ascii_alphabetic(), Error::<T>::InvalidSchemaNameCharacters); |
Collaborator
There was a problem hiding this comment.
nit: the comment isn't precisely true, otherwise you'd just check for !~[0-9]
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Goal
The goal of this PR is to implement the extrinsics, RPCs and unit tests for Intents and IntentGroups.
Closes #2564
Discussion
Checklist