StatefulStorage: bump max page id from 16 to 32#1959
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1959 +/- ##
=======================================
Coverage 83.13% 83.13%
=======================================
Files 56 56
Lines 4530 4530
=======================================
Hits 3766 3766
Misses 764 764 ☔ View full report in Codecov by Sentry. |
|
Just noting that we chose the page limit we did initially because we determined that number of follows is unrealistic. (Ignoring the fact that this is exactly one of MeWe's test cases, but even they recognize that it's not a realistic scenario.) So, do we want to allow anyone to consume that much on-chain storage, or should we keep a smaller limit? In reality only a bot or poorly designed provider platform would generate that many follows. (Though that does raise the question: MeWe actually allows that many follows, even though it's unrealistic...) I guess maybe we bump the limit for now to, but maybe we should consider other solutions in the future (like perhaps a "soft" limit that can be overridden by governance on a per-user basis). |
wilwade
left a comment
There was a problem hiding this comment.
I am good with these changes.
# Goal The goal of this PR is address the max page id issue discovered via running the simulation Closes #198 # WARNING This should not get merged until frequency-chain/frequency#1959 is merged and Deployed on Frequency mainnet # Discussion - This is companion PR related to the change on frequency chain frequency-chain/frequency#1959 # Checklist - [x] Tests updated
Goal
The goal of this PR is to make sure we are not going to have any issue to be able to store at 7k private follows
Closes #1958
Discussions
Checklist