schemas: PoV compatible changes#1743
Merged
Merged
Conversation
|
⏳ Running benchmarks and calculating weights. DO NOT MERGE! A new commit will be added upon completion... |
Codecov Report
@@ Coverage Diff @@
## main #1743 +/- ##
==========================================
- Coverage 88.00% 87.60% -0.41%
==========================================
Files 51 52 +1
Lines 4270 4339 +69
==========================================
+ Hits 3758 3801 +43
- Misses 512 538 +26
📣 Codecov offers a browser extension for seamless coverage viewing on GitHub. Try it in Chrome or Firefox today! |
|
✅ Finished running benchmarks. Updated weights have been committed to this PR branch in commit afe3711. |
61723a0 to
0629206
Compare
|
⏳ Running benchmarks and calculating weights. DO NOT MERGE! A new commit will be added upon completion... |
|
✅ Finished running benchmarks. Updated weights have been committed to this PR branch in commit 344b1a7. |
demisx
pushed a commit
that referenced
this pull request
Nov 2, 2023
344b1a7 to
965da26
Compare
JoeCap08055
reviewed
Nov 6, 2023
JoeCap08055
reviewed
Nov 6, 2023
JoeCap08055
reviewed
Nov 6, 2023
JoeCap08055
reviewed
Nov 6, 2023
Collaborator
|
Looks pretty good. Perhaps add/update e2e tests for all pallets to use the new RPC? |
shannonwells
approved these changes
Nov 7, 2023
|
⏳ Running benchmarks and calculating weights. DO NOT MERGE! A new commit will be added upon completion... |
|
✅ Finished running benchmarks. Updated weights have been committed to this PR branch in commit 8df2685. |
mattheworris
approved these changes
Nov 10, 2023
mattheworris
left a comment
Collaborator
There was a problem hiding this comment.
Solid.
[Read through code, ran tests,
caveat: I don't have much experience with storage migration, but nothing smells off]
| This PoV improvement would not affect extrinsic weights in this pallet, but it would directly affect any | ||
| pallet that is dependent on **Schemas** pallet. Some of these pallets are **Messages** and | ||
| **Stateful-Storage**. After these changes we are expecting see to see around 30-60KiB decrease in PoV | ||
| for `MaxEncodedLen` mode. |
wilwade
reviewed
Nov 13, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Goal
The goal of this PR is to split schemas and the model into 2 separate storages so that we can limit the size of PoV being accessed from other pallets.
Closes #1742
Checklist