Merged
Conversation
f517dfa to
fe063c5
Compare
mattheworris
commented
Jun 8, 2023
mattheworris
commented
Jun 8, 2023
mattheworris
commented
Jun 8, 2023
mattheworris
commented
Jun 8, 2023
|
⏳ Running benchmarks and calculating weights. DO NOT MERGE! A new commit will be added upon completion... |
|
⏳ Running benchmarks and calculating weights. DO NOT MERGE! A new commit will be added upon completion... |
|
✅ Finished running benchmarks. Updated weights have been committed to this PR branch in commit a892003. |
demisx
pushed a commit
that referenced
this pull request
Jun 12, 2023
Codecov Report
@@ Coverage Diff @@
## main #1590 +/- ##
==========================================
+ Coverage 72.93% 73.02% +0.09%
==========================================
Files 49 49
Lines 4751 4745 -6
==========================================
Hits 3465 3465
+ Misses 1286 1280 -6
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
rlaferla
reviewed
Jun 13, 2023
rlaferla
reviewed
Jun 13, 2023
rlaferla
reviewed
Jun 13, 2023
rlaferla
reviewed
Jun 13, 2023
rlaferla
reviewed
Jun 13, 2023
rlaferla
reviewed
Jun 13, 2023
rlaferla
reviewed
Jun 13, 2023
rlaferla
reviewed
Jun 13, 2023
|
⏳ Running benchmarks and calculating weights. DO NOT MERGE! A new commit will be added upon completion... |
|
✅ Finished running benchmarks. Updated weights have been committed to this PR branch in commit 5374d58. |
enddynayn
reviewed
Jun 15, 2023
| // the descriptions of these configs. | ||
| parameter_types! { | ||
| pub MaxProposalWeight: frame_support::weights::Weight = | ||
| Perbill::from_percent(50) * common_runtime::constants::MAXIMUM_BLOCK_WEIGHT; |
Collaborator
There was a problem hiding this comment.
It is the same value as Polkadot uses. I believe it to be ok, but we will want to test governance upgrade on testnet.
Collaborator
Author
There was a problem hiding this comment.
This value is in the unit testing mocks, which needed to be changed to pass the unit tests.
The value defined in runtime is (runtime/frequency/src/lib.rs):
type MaxProposalWeight = MaxCollectivesProposalWeight;
// Which resolves to this:
pub MaxCollectivesProposalWeight: Weight = Perbill::from_percent(50) * RuntimeBlockWeights::get().max_block;
wilwade
reviewed
Jun 15, 2023
Collaborator
wilwade
left a comment
There was a problem hiding this comment.
One open question on the metadata_at stuff, otherwise all good to go from my side!
Additional tests run:
- Build mainnet and it connected to the network ✅
- Export metadata still works ✅
wilwade
approved these changes
Jun 15, 2023
Collaborator
wilwade
left a comment
There was a problem hiding this comment.
🎉 Lots of great work in there. Thanks!
2 tasks
This was referenced Jun 20, 2023
Closed
wilwade
added a commit
that referenced
this pull request
Jun 20, 2023
# Goal The goal of this PR is to update all remaining dependencies. In part a follow up to #1590 # Discussion - The 0.9.42 branch had moved to `9326fee1fb853be3d5096a2beef5fb46624e9d75` Polkadot release did as well. https://github.com/paritytech/substrate/commits/polkadot-v0.9.42 - General upgrade of additional packages
shannonwells
pushed a commit
that referenced
this pull request
Apr 16, 2024
# Goal The goal of this PR is upgrade Polkadot to v0.9.42 Polkadot Release Notes: https://github.com/paritytech/polkadot/releases/tag/v0.9.42 https://github.com/paritytech/polkadot/releases/tag/v0.9.41 https://github.com/paritytech/polkadot/releases/tag/v0.9.40 Polkadot Release Analysis: https://forum.polkadot.network/t/polkadot-release-analysis-v0-9-41-v0-9-42/2828/1 Closes #1472 Closes #1270 Closes #1332 # Discussion - v0.9.40 was not working and there was evidence that changes in v0.9.42 were related, so we decided to jump ahead to v0.9.42 <!-- List discussion items --> # Runtime Migrations Included - [x] paritytech/polkadot#6937 - [x] paritytech/substrate#13715 - [x] paritytech/substrate#13936 - [x] paritytech/polkadot#7114 - [x] Further all migrations from 9.38+ are included: paritytech/polkadot#7162) # Checklist - [x] Chain spec updated - [ ] Custom RPC OR Runtime API added/changed? Updated js/api-augment. - [ ] Design doc(s) updated - [ ] Tests added - [ ] Benchmarks added - [x] Weights updated # Tests Performed - [x] `make ci-local` -- Passing (includes lint, docs, unit-test and integration-test) - [x] `make start-native` -- Successfully attached debugger when creating MSA with Polkadot UI - [x] `make start-relay` -- Docker Containers successfully started, but too slow in emulation on Apple Silicon M2. - [x] `make upgrade-local` -- Successfully started local relay network and upgraded to a newer test runtime. - [x] `make upgrade-local` -- Successfully updated a node running the current version on branch `main` --------- Co-authored-by: Frequency CI [bot] <do-not-reply@users.noreply.github.com> Co-authored-by: Matthew Orris <--help> Co-authored-by: Robert La Ferla <robert@onemsg.co>
shannonwells
pushed a commit
that referenced
this pull request
Apr 16, 2024
# Goal The goal of this PR is to update all remaining dependencies. In part a follow up to #1590 # Discussion - The 0.9.42 branch had moved to `9326fee1fb853be3d5096a2beef5fb46624e9d75` Polkadot release did as well. https://github.com/paritytech/substrate/commits/polkadot-v0.9.42 - General upgrade of additional packages
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Goal
The goal of this PR is upgrade Polkadot to v0.9.42
Polkadot Release Notes:
https://github.com/paritytech/polkadot/releases/tag/v0.9.42
https://github.com/paritytech/polkadot/releases/tag/v0.9.41
https://github.com/paritytech/polkadot/releases/tag/v0.9.40
Polkadot Release Analysis:
https://forum.polkadot.network/t/polkadot-release-analysis-v0-9-41-v0-9-42/2828/1
Closes #1472
Closes #1270
Closes #1332
Discussion
Runtime Migrations Included
ReportsByKindIndexparitytech/polkadot#7114Checklist
Tests Performed
make ci-local-- Passing (includes lint, docs, unit-test and integration-test)make start-native-- Successfully attached debugger when creating MSA with Polkadot UImake start-relay-- Docker Containers successfully started, but too slow in emulation on Apple Silicon M2.make upgrade-local-- Successfully started local relay network and upgraded to a newer test runtime.make upgrade-local-- Successfully updated a node running the current version on branchmain