Description

The actual fix is saving the patched node.
This effectively reverts (part of)
0051309

So the simplest fix would be:

    patch(tbody, tbodyNew)

->

    tbody = patch(tbody, tbodyNew) as unknown as HTMLTableSectionElement;

(however the typing is anyway wrong here, but that doesn't really matter here)

I am not really sure why thats relevant for patch, but I could not get it working without.
I thought that the patch always replaces the "diff", but maybe I don't understand Snabbdom correctly^^

Also I also noticed that there is an edge case when on the first load the list shows no nodes
and in subsequent reloads it gets nodes, it will append the node list always at the bottom, which may not be correct.

To avoid this and to make it more robust,
this component is now refactored, and uses an extra container div thats always in the dom.

That way it already reserves a place in the dom, even when no nodes are there yet.

If I should split this into a separate pull request, just tell me.
However as I anyway refactored most code, it did not make sense to me to split this up.

Motivation and Context

Closes: #138

And also makes the list more robust to changes (e.g. if the first dataset is empty and further updates contain nodes)

How Has This Been Tested?

Tested on ff and chrome.

To test the behavior on what happens when there are first no nodes, i temporarily decreased the refresh timer and I also mocked the data.

let first = true

export const main = () => {
  function handleData(data: { links: Link[]; nodes: Node[]; timestamp: string }[]) {
    // ...
    newnodes = first ? [] : newnodes
    first = false

    return {
      // ...
    };
  }

Screenshots/links:

Checklist:

• [x ] My code follows the code style of this project. (CI will test it anyway and also needs approval)
• [ ] My change requires a change to the documentation.
  • [ ] I have updated the documentation accordingly.