Skip to content

fix(client): allow identical challenge ids multiple superblocks#61982

Merged
ojeytonwilliams merged 1 commit intofreeCodeCamp:mainfrom
Sembauke:fix/allow-double-ids-in-multiple-superblocks
Aug 30, 2025
Merged

fix(client): allow identical challenge ids multiple superblocks#61982
ojeytonwilliams merged 1 commit intofreeCodeCamp:mainfrom
Sembauke:fix/allow-double-ids-in-multiple-superblocks

Conversation

@Sembauke
Copy link
Copy Markdown
Member

Checklist:

Closes #XXXXX

Copy link
Copy Markdown
Contributor

@ojeytonwilliams ojeytonwilliams left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In an ideal world, this would run against a unique list of blocks.

I have some plans to refactor the build so each block is only built once and we refactor this test then. But that's a problem for later.

LGTM 👍

@Sembauke Sembauke marked this pull request as ready for review August 29, 2025 10:37
@Sembauke Sembauke requested a review from a team August 29, 2025 10:37
@ojeytonwilliams ojeytonwilliams enabled auto-merge (squash) August 29, 2025 10:51
@ojeytonwilliams ojeytonwilliams merged commit 793f81b into freeCodeCamp:main Aug 30, 2025
12 of 14 checks passed
@Sembauke Sembauke deleted the fix/allow-double-ids-in-multiple-superblocks branch August 31, 2025 18:43
zairahira pushed a commit to zairahira/freeCodeCamp that referenced this pull request Sep 4, 2025
ahmaxed pushed a commit to ojeytonwilliams/freeCodeCamp that referenced this pull request Sep 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants