Skip to content

feat(curriculum): add sql and bash review page#61739

Merged
jdwilkin4 merged 6 commits intofreeCodeCamp:mainfrom
larymak:feat-add-bash-and-sql-review-page
Sep 11, 2025
Merged

feat(curriculum): add sql and bash review page#61739
jdwilkin4 merged 6 commits intofreeCodeCamp:mainfrom
larymak:feat-add-bash-and-sql-review-page

Conversation

@larymak
Copy link
Copy Markdown
Contributor

@larymak larymak commented Aug 8, 2025

Checklist:

Closes freeCodeCamp/CurriculumExpansion#904

@github-actions github-actions bot added the scope: curriculum Lessons, Challenges, Projects and other Curricular Content in curriculum directory. label Aug 8, 2025
@larymak larymak marked this pull request as ready for review August 11, 2025 06:05
@larymak larymak added status: waiting review To be applied to PR's that are ready for QA, especially when additional review is pending. full stack cert labels Aug 11, 2025
@majestic-owl448 majestic-owl448 added status: waiting update Is awaiting update, after feedback or request for changes and removed status: waiting review To be applied to PR's that are ready for QA, especially when additional review is pending. labels Aug 11, 2025
@larymak larymak added status: waiting review To be applied to PR's that are ready for QA, especially when additional review is pending. and removed status: waiting update Is awaiting update, after feedback or request for changes labels Aug 19, 2025
Copy link
Copy Markdown
Contributor

@majestic-owl448 majestic-owl448 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One this that the review would benefit from is also adding how to use the retrieved values, at least in what shape they are

@gikf gikf added the MERGE CONFLICT! To be applied to PR's that have a merge conflict and need updating label Aug 26, 2025
@majestic-owl448 majestic-owl448 removed the MERGE CONFLICT! To be applied to PR's that have a merge conflict and need updating label Aug 27, 2025
@majestic-owl448
Copy link
Copy Markdown
Contributor

PR migrated to new structure

@majestic-owl448 majestic-owl448 added status: waiting update Is awaiting update, after feedback or request for changes and removed status: waiting review To be applied to PR's that are ready for QA, especially when additional review is pending. labels Aug 29, 2025
@larymak larymak added status: waiting review To be applied to PR's that are ready for QA, especially when additional review is pending. and removed status: waiting update Is awaiting update, after feedback or request for changes labels Sep 4, 2025
Copy link
Copy Markdown
Contributor

@majestic-owl448 majestic-owl448 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you

the only other thing I can think of is that this is not in the format

- **some topic**: some explanation

```
some code here if necessary
```

that the first created reviews had established

@jdwilkin4 jdwilkin4 added status: waiting update Is awaiting update, after feedback or request for changes and removed status: waiting review To be applied to PR's that are ready for QA, especially when additional review is pending. labels Sep 7, 2025
Copy link
Copy Markdown
Contributor

@jdwilkin4 jdwilkin4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Once this review page is updated to the format as the other review pages, then this can be merged in

@larymak larymak removed the status: waiting update Is awaiting update, after feedback or request for changes label Sep 8, 2025
@larymak larymak added the status: waiting review To be applied to PR's that are ready for QA, especially when additional review is pending. label Sep 8, 2025
@larymak larymak requested a review from jdwilkin4 September 8, 2025 09:01
@jdwilkin4 jdwilkin4 merged commit 0038072 into freeCodeCamp:main Sep 11, 2025
14 of 19 checks passed
@larymak larymak deleted the feat-add-bash-and-sql-review-page branch September 12, 2025 05:12
ahmaxed pushed a commit to ojeytonwilliams/freeCodeCamp that referenced this pull request Sep 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

scope: curriculum Lessons, Challenges, Projects and other Curricular Content in curriculum directory. status: waiting review To be applied to PR's that are ready for QA, especially when additional review is pending.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add bash and SQL review page to main

5 participants