Skip to content

fix(client): Change cert name to "Front End Development Libraries"#42511

Closed
PrashantSakre wants to merge 2 commits intofreeCodeCamp:mainfrom
PrashantSakre:fix/cer-name-settings
Closed

fix(client): Change cert name to "Front End Development Libraries"#42511
PrashantSakre wants to merge 2 commits intofreeCodeCamp:mainfrom
PrashantSakre:fix/cer-name-settings

Conversation

@PrashantSakre
Copy link
Contributor

@PrashantSakre PrashantSakre commented Jun 15, 2021 •
edited by raisedadead
Loading

Checklist:

  • I have read freeCodeCamp's contribution guidelines.
  • My pull request has a descriptive title (not a vague title like Update index.md)
  • My pull request targets the main branch of freeCodeCamp.
  • I have tested these changes either locally on my machine, or GitPod.

Closes #42502

@PrashantSakre PrashantSakre requested a review from a team June 15, 2021 17:03
@gitpod-io
Copy link

gitpod-io bot commented Jun 15, 2021

@github-actions github-actions bot added the platform: learn UI side of the client application that needs familiarity with React, Gatsby etc. label Jun 15, 2021
raisedadead
raisedadead reviewed Jun 15, 2021
View reviewed changes
Copy link
Member

@raisedadead raisedadead left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work, could you expand the tests too? This seems like a discernable bug. If you need help, let us know in the chat.

@raisedadead raisedadead changed the title fix(client): Change cert name to "Front End Development Libraries" on… fix(client): Change cert name to "Front End Development Libraries" Jun 15, 2021
@raisedadead raisedadead mentioned this pull request Jun 15, 2021
Merged
4 tasks
@heysujal
Copy link
Contributor

heysujal commented Jun 15, 2021

Why his code is failing some tests?

raisedadead
raisedadead reviewed Jun 15, 2021
View reviewed changes
client/src/resources/certAndProjectMap.js
{
id: '561acd10cb82ac38a17513bc',
title: 'Front End Libraries',
title: 'Front End Development Libraries',
Copy link
Member

@raisedadead raisedadead Jun 15, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changing this may not be as trivial as we want or think it to be @moT01

cc: @ShaunSHamilton

Copy link
Member

@ShaunSHamilton ShaunSHamilton Jun 15, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is likely mostly related with: #39590 and #41563

At some point, I do hope to give #39695 another go, as this certAndProjectMap proves to be a pain point.

Until then, these files need to be changed to match:

Copy link
Contributor

@ojeytonwilliams ojeytonwilliams Jun 16, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We really need to put aside some time to work on #39695, since it's a huge exercise in frustration to make a seemingly trivial change like this.

@moT01
Copy link
Member

moT01 commented Jun 15, 2021

I would have to dig into it. Here's the error for the failing test. It's in this file. It's looks like it's using the title as a key or something from here, but can't find it with the new title.

@moT01 moT01 mentioned this pull request Jun 15, 2021
Closed
@raisedadead
Copy link
Member

raisedadead commented Jun 15, 2021

I propose we keep this PR where it only changes the settings page and add the test to go with it, and let @ShaunSHamilton continue the work on the more involving bits.

Shaun if you agree please guide us with a confirmation.

@ShaunSHamilton
Copy link
Member

ShaunSHamilton commented Jun 15, 2021

I propose we keep this PR where it only changes the settings page and add the test to go with it,

@raisedadead Sounds fine 👍 . This PR, then will not close the issue. As such, I will comment on the issue with what needs to be done.

@ShaunSHamilton ShaunSHamilton mentioned this pull request Jun 15, 2021
Closed
@github-actions github-actions bot added scope: curriculum Lessons, Challenges, Projects and other Curricular Content in curriculum directory. scope: i18n language translation/internationalization. Often combined with language type label labels Jun 16, 2021
@PrashantSakre
Copy link
Contributor Author

PrashantSakre commented Jun 16, 2021

Sorry, I thought this is small fix. So you continue work on this. For now I am not working on this issue.

@raisedadead
Copy link
Member

raisedadead commented Jun 16, 2021

Closing as requested.

@ojeytonwilliams
Copy link
Contributor

ojeytonwilliams commented Jun 16, 2021

Sorry, @PrashantSakre, it's completely our fault. We didn't think through the implications of a relatively innocents-seeming change. Thanks for taking the time to contribute, though, it's definitely appreciated.

@PrashantSakre
Copy link
Contributor Author

PrashantSakre commented Jun 16, 2021

So kind, Thank you so much

@PrashantSakre PrashantSakre deleted the fix/cer-name-settings branch June 16, 2021 17:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@raisedadead raisedadead raisedadead left review comments

@ojeytonwilliams ojeytonwilliams ojeytonwilliams left review comments

@ShaunSHamilton ShaunSHamilton ShaunSHamilton left review comments

Assignees

No one assigned

Labels

platform: learn UI side of the client application that needs familiarity with React, Gatsby etc. scope: curriculum Lessons, Challenges, Projects and other Curricular Content in curriculum directory. scope: i18n language translation/internationalization. Often combined with language type label

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Change cert name to "Front End Development Libraries" on settings page

6 participants

@PrashantSakre @heysujal @moT01 @raisedadead @ShaunSHamilton @ojeytonwilliams