feat/fix(client): refactor certMap and fix date propType#39695
feat/fix(client): refactor certMap and fix date propType#39695ShaunSHamilton wants to merge 30 commits intofreeCodeCamp:mainfrom
Conversation
cf0cb82 to
2f607a9
Compare
|
Dev Team, this implementation renders the certs on the settings page in the order provided by their Is this implementation ok? Or, should it match the current (production) order? |
|
Hey Shaun, apologies for the delay getting to this. Is this PR ready for review?
So, this would just be the order Legacy Front End, Legacy Back End and so on appear (after Legacy Full Stack Certification)? I don't think that matters much and we can always change their order properties. |
|
I was thinking about this PR from an internationalisation perspective. What I think we we need to do is add some additional properties to the certificates. The approach here, where properties of the title are used in the logic, is likely to cause problems when the titles are translated. Could we add more properties to the frontmatter and use those instead? For instance using |
|
@ojeytonwilliams No, this is not ready for review. I keep pushing it back as changes are made to the associated files.
Very good point. I will be able to spend some time looking through this kind of this, these holidays. I would like clarification, though, on where and what I can change/add? I am not a fan of giving some certs/projects properties, and not others. So, could I adjust all files for consistency, or would this be undesirable? |
I'm working on them too, but I'll fix any conflicts (just ping me in chat if I forget).
Changing them all is fine by me - there are only 15 certificate files after all. If we were talking about a change that's only relevant for a small number of challenges, we could consider defaulting when that property is absent. Since it's a small number, I agree that consistency is the main thing. |
|
FYI: one thing I'm trying out is adding info like to the frontmatter. |
|
@ojeytonwilliams Before I do any more on this, and need to rework with rebasing, I would prefer to get:
Both of the above merged, as they touch associated files. Will the above be blocked by this Code Freeze? |
|
We are going to be doing a head branch rename. I understand this is a high-priority PR. I can stow this on a separate branch on the main repo for now if you all prefer. |
This is not really high-priority. So, I do not mind whether you close this and move it to a separate branch or just close. Once the related PRs are sorted, I can get back to this with a new branch, if need be. |
|
I have gone ahead and re-targeted this to the main branch that we just created. You may need a rebase before this is actually merged |
|
Hi @ShaunSHamilton nice work on the other two PRs 🎉 I finally got around to converting from .markdown to .yml so there might be a few conflicts. Turned out the conversion was simply a matter of deleting everything that wasn't already yaml, so it should not be a painful rebase. If that proves not to be the case, let me know and I'll try and sort it out. |
|
@ojeytonwilliams Thank you. The conflicts are minimal, and I will probably merge the current changes from |
|
Cool, cool - no rush at all. We can always hop on a call if there's something you'd like to discuss. Otherwise, I'm looking forward to the rework. |
|
Closing as stale, and would hold back TS migration. Idea still useable, in principle. |
Checklist:
Update index.md)masterbranch of freeCodeCamp.