Fix typo and add tests for bonfire Arguments Optional#416
Merged
terakilobyte merged 1 commit intofreeCodeCamp:stagingfrom May 5, 2015
pahlsson:pahlsson-bonfire-args-optional-fix
Merged
Fix typo and add tests for bonfire Arguments Optional#416terakilobyte merged 1 commit intofreeCodeCamp:stagingfrom pahlsson:pahlsson-bonfire-args-optional-fix
terakilobyte merged 1 commit intofreeCodeCamp:stagingfrom
pahlsson:pahlsson-bonfire-args-optional-fix
Conversation
Add tests for the second argument and fix a typo.
Contributor
|
The typo is a good fix, but I'd like to ask if you tested this. I attempted to run this code and it failed to verify correctly. |
terakilobyte
added a commit
that referenced
this pull request
May 5, 2015
Fix typo and add tests for bonfire Arguments Optional
This was referenced Sep 23, 2020
This was referenced Apr 13, 2021
This was referenced Apr 20, 2021
This was referenced Apr 27, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The instructions for the bonfire Arguments Optional say to return
undefinedwhen either argument isn't a valid number, but the tests only cover the first argument.This adds tests for the second argument as well, and fixes a typo.