Skip to content

translated some Chinese curriculum files#40531

Merged
RandellDawson merged 2 commits intofreeCodeCamp:masterfrom
miyaliu666:fix/40463
Jan 8, 2021
Merged

translated some Chinese curriculum files#40531
RandellDawson merged 2 commits intofreeCodeCamp:masterfrom
miyaliu666:fix/40463

Conversation

@miyaliu666
Copy link
Copy Markdown
Member

Checklist:

  • I have read freeCodeCamp's contribution guidelines.
  • My pull request has a descriptive title (not a vague title like Update index.md)
  • My pull request targets the master branch of freeCodeCamp.
  • All the files I changed are in the same world language, for example: only English changes, or only Chinese changes, etc.

@gitpod-io
Copy link
Copy Markdown

gitpod-io bot commented Dec 24, 2020

@miyaliu666 miyaliu666 changed the title Fix/40463 translated some Chinese curriculum files Dec 24, 2020
@miyaliu666 miyaliu666 added language: Chinese scope: curriculum Lessons, Challenges, Projects and other Curricular Content in curriculum directory. labels Dec 24, 2020
@moT01
Copy link
Copy Markdown
Member

moT01 commented Dec 29, 2020

Do we have a process for keeping track of what files have been fixed or looked over? Should we just check the box next to each lesson on the issue after this gets merged? I think some files don't need any changes - we can probably just remove those from the issues when they are found - just trying to get on the same page for these.

@miyaliu666
Copy link
Copy Markdown
Member Author

Do we have a process for keeping track of what files have been fixed or looked over? Should we just check the box next to each lesson on the issue after this gets merged? I think some files don't need any changes - we can probably just remove those from the issues when they are found - just trying to get on the same page for these.

Just saw this comment. If I understand right, I've checked the first four boxes of issues #40463. For the last one (task #5), we'll fix them on Crowdin later as Randy and I agreed before. Not sure if we can merge this PR now. All the content is fine. Do you want to take a look? @RandellDawson

@RandellDawson
Copy link
Copy Markdown
Member

Just saw this comment. If I understand right, I've checked the first four boxes of issues #40463. For the last one (task #5), we'll fix them on Crowdin later as Randy and I agreed before. Not sure if we can merge this PR now. All the content is fine. Do you want to take a look? @RandellDawson

@miyaliu666 Since we do not have a finalized date for Crowdin integration, it would probably be better to go ahead and translate as many of these as possible. We will upload all these changes the Chinese translation team as been working on (via GitHub PRs) into Crowdin's translation memory before opening up the translation of challenges on Crowdin.

@RandellDawson
Copy link
Copy Markdown
Member

I am merging this PR, so we can push the changes up to Crowdin.

@RandellDawson RandellDawson merged commit 9770cd0 into freeCodeCamp:master Jan 8, 2021
@RandellDawson
Copy link
Copy Markdown
Member

@miyaliu666 Thank you for your contribution to the page! 👍
We're happy to accept these changes, and look forward to future contributions. 🎉

ahmaxed pushed a commit to ahmaxed/freeCodeCamp that referenced this pull request Jan 10, 2021
* translate task #1 - #4

* add translation of zhang-suen-thinning and markov algorithm

Co-authored-by: S1ngS1ng <liuxing0514@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

scope: curriculum Lessons, Challenges, Projects and other Curricular Content in curriculum directory.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants