Fix no user comment display#215
Closed
terakilobyte wants to merge 6 commits intofreeCodeCamp:masterfrom
terakilobyte:fix-no-user-comment-display
Closed
Fix no user comment display#215terakilobyte wants to merge 6 commits intofreeCodeCamp:masterfrom terakilobyte:fix-no-user-comment-display
terakilobyte wants to merge 6 commits intofreeCodeCamp:masterfrom
terakilobyte:fix-no-user-comment-display
Conversation
…n if no user, reject attempted comments if no user and no author
|
Would it be better to compare the IDs? Right now it's easy pretend to be someone since usernames aren't unique but if they ever were then someone could comment logged in as themselves while providing author details saying they were someone else. |
Contributor
Author
|
usernames are supposed to be unique |
Contributor
Author
|
Replaced with an improve pull request |
EdTriplett
added a commit
to EdTriplett/freeCodeCamp
that referenced
this pull request
Nov 1, 2018
Add authors still not named for certain books and removed italic from other author's names in order for all content to follow the same pattern. Done so from line freeCodeCamp#215 (others) until the end.
5 tasks
This was referenced Jan 9, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.