Gitter chat embed fix#184
Merged
freeCodeCamp merged 1 commit intomasterfrom Mar 12, 2015
unknown repository
Merged
Conversation
Added https://*.gitter.im to 'frameSrc' CSP
Contributor
|
Chat embed works for me. Does not seem to be blocked by helmet. |
Author
|
Does it work for you in Firefox? I see this in Firefox: http://i.imgur.com/xuUEnw2.png and I'm seeing this in the console which lead me to helmet: http://i.imgur.com/4SMFRhb.png |
Contributor
|
Yes it is not loading in FF for me either. But I am seeing a different error message
@jameskopacz Have you tested this locally to verify it works. Seems like it still works in chrome if I change the embed link to http. |
Author
|
Weird. I'm seeing that message but above it is the CSP error. Adding the fix does work locally: http://i.imgur.com/RnRBbRs.png |
Collaborator
|
@jameskopacz Wow, I had no idea this was caused by Helmet, but you're right. This fixes it. Thanks for fixing this! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added https://*.gitter.im to 'frameSrc' CSP
Fixes #182