fixes for various typos in the Applied Visual Design section#12932
Merged
Greenheart merged 1 commit intofreeCodeCamp:stagingfrom Jan 28, 2017
erichartline:fix/visual-design-typos
Merged
fixes for various typos in the Applied Visual Design section#12932Greenheart merged 1 commit intofreeCodeCamp:stagingfrom erichartline:fix/visual-design-typos
Greenheart merged 1 commit intofreeCodeCamp:stagingfrom
erichartline:fix/visual-design-typos
Conversation
Greenheart
suggested changes
Jan 28, 2017
Member
Greenheart
left a comment
There was a problem hiding this comment.
@wildlifehexagon Nice work! 😄
There's just one small thing that needs further discussion.
-
npm testpasses - Tested locally
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
Member
|
I'm not at my computer at the minute, but does making the `code` tags a
child if the `a` tag help with formatting?
…On Saturday, 28 January 2017, Samuel Plumppu ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In seed/challenges/01-responsive-web-design/applied-visual-design.json
<#12932>:
> @@ -1143,7 +1143,7 @@
}
],
"description": [
- "<code>Google Fonts</code> is a great way to find free fonts to use in a project.",
+ "<code><a href='https://fonts.google.com/' target='_blank'>Google Fonts</a></code> is a great way to find free fonts to use in a project.",
I think we should add it now when we're at it 😊
@freeCodeCamp/moderators
<https://github.com/orgs/freeCodeCamp/teams/moderators> What do you think
about this link? How should it be formatted?
—
You are receiving this because you are on a team that was mentioned.
Reply to this email directly, view it on GitHub
<#12932>, or mute the
thread
<https://github.com/notifications/unsubscribe-auth/ARtk5shCht2bo1LXty6Kszguf27z7ZfQks5rW6XSgaJpZM4LwZry>
.
|
Member
Contributor
Author
|
Thanks for the help! I made the change, but I have a question before I re-submit. I noticed that there is a square box after the link now -- is that supposed to be there? Here's what I'm seeing: http://imgur.com/a/a37ln |
Member
|
It's a link icon (square with arrow going from center to top right), which
I think I've seen for external links before.
It just seems like it didn't load properly in your browser. Might be a
network- or browser extension-issue.
lördag 28 januari 2017 skrev Eric Hartline <notifications@github.com>:
… @Bouncey <https://github.com/Bouncey> @Greenheart
<https://github.com/Greenheart>
Thanks for the help! I made the change, but I have a question before I
re-submit. I noticed that there is a square box after the link now -- is
that supposed to be there?
Here's what I'm seeing: http://imgur.com/a/a37ln
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#12932 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AF12KbqiONfqfJ0s1f-f6_HOf6IpMV0Nks5rW7y3gaJpZM4LwZry>
.
|
Member
|
@wildlifehexagon I just realized, we might not even need the What would you say about removing |
Contributor
Author
|
@Greenheart Great point, the code isn't really necessary. I'll resend without it. |
Greenheart
approved these changes
Jan 28, 2017
Member
|
@wildlifehexagon But now we know it works at least 😉 Thanks for fixing this! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pre-Submission Checklist
stagingbranch of freeCodeCamp.fix/,feature/, ortranslate/(e.g.fix/signin-issue)npm test. Usegit commit --amendto amend any fixes.Type of Change
Checklist:
Description
I fixed typos on the following pages:
Applied Visual Design: Adjust the Background-color Property of Text
Applied Visual Design: Learn about Tertiary Colors
Applied Visual Design: Adjusting the Color of Various Elements to Complementary Colors
Applied Visual Design: Adjust the Hue of a Color
Applied Visual Design: Create a Gradual CSS Linear Gradient
Applied Visual Design: Use the CSS Transform Property to Scale an Element on Hover
Applied Visual Design: Create a More Complex Shape Using CSS and HTML
Applied Visual Design: Learn How CSS Keyframes and Animation Properties Work
Applied Visual Design: Make a CSS Heartbeat using an Infinite Animation Count
Applied Visual Design: Learn How Bezier Curves Work
Applied Visual Design: Use a Bezier Curve to Move a Graphic
I also added a link to Google Fonts on the Applied Visual Design: Use a Google Font page. Feels like it would be helpful so the camper can see the site for themselves.