Skip to content

Improvements to adv. algos and data structures#12823

Merged
raisedadead merged 1 commit intofreeCodeCamp:stagingfrom
bonham000:fix/adv-algos-and-data-structures
Jan 28, 2017
Merged

Improvements to adv. algos and data structures#12823
raisedadead merged 1 commit intofreeCodeCamp:stagingfrom
bonham000:fix/adv-algos-and-data-structures

Conversation

@bonham000
Copy link
Copy Markdown
Contributor

@bonham000 bonham000 commented Jan 25, 2017 •
edited
Loading

Pre-Submission Checklist

  • Your pull request targets the staging branch of freeCodeCamp.
  • Branch starts with either fix/, feature/, or translate/ (e.g. fix/signin-issue)
  • You have only one commit (if not, squash them into one commit).
  • All new and existing tests pass the command npm test. Use git commit --amend to amend any fixes.

Type of Change

  • Small bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds new functionality)
  • Breaking change (fix or feature that would change existing functionality)
  • Add new translation (feature adding new translations)

Checklist:

  • Tested changes locally.
  • Closes currently open issue (replace XXXX with an issue no): Closes #XXXX

Description

Round II of previous PR containing many improvements to Advanced Data Structures & Algorithms Challenges:

  • Reorganized challenge sequence and removed repeated challenges.
  • Verified tests for many of the challenges.
  • Moved all sorting algorithms to the adv. algorithms section and tested these.
  • Improved formatting/styling of text in several places.

These challenges still need a lot more work but this is a good first step toward moving them in the right direction. Remaining improvements to be tracked in this issue.

@BerkeleyTrue BerkeleyTrue added the status: waiting review To be applied to PR's that are ready for QA, especially when additional review is pending. label Jan 25, 2017
@no-stack-dub-sack
Copy link
Copy Markdown
Member

no-stack-dub-sack commented Jan 28, 2017

LGTM!

@raisedadead I think this should probably also be merged before #12720 since these challenges also probably had released on dates added to them in that PR also.

@bonham000
Copy link
Copy Markdown
Contributor Author

bonham000 commented Jan 28, 2017

Mainly looking to get this merged so we can continue having others work on reviewing these challenges (as referenced here). There's a good bit of work to be done on this section and I was hoping to do it in incremental pieces.

@raisedadead raisedadead merged commit 166826d into freeCodeCamp:staging Jan 28, 2017
@raisedadead raisedadead removed the status: waiting review To be applied to PR's that are ready for QA, especially when additional review is pending. label Jan 28, 2017
@raisedadead
Copy link
Copy Markdown
Member

raisedadead commented Jan 28, 2017

@bonham000 @no-stack-dub-sack thanks for the pull request and the QA.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@raisedadead raisedadead raisedadead approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@bonham000 @no-stack-dub-sack @raisedadead @BerkeleyTrue