revise copy for intro array challenge#12817
Conversation
|
I think at least part of both this challenge and the Add-KeyValue-Pairs challenge should be converted into intro sections. There is a lot of text on these challenges and most of it doesn't actually have to do with the challenge exercise. Could this be split into a challenge and an intro like this? cc @freeCodeCamp/moderators Thoughts? |
|
I agree with you @dhcodes , this is a bit wordy IMHO. |
|
@dhcodes @raisedadead I think that's an excellent idea and was def getting concerned with the wordiness of it all. If this is an option, I'd gladly do it. I think the information is important, and adds context to the section (otherwise they just become more object and array challenges). Only the most dedicated campers will probably end up reading it, but hey, at least no one can say we didn't provide the info |
4a5111a to
d88c958
Compare
|
This looks good to me! |
|
@no-stack-dub-sack - with the intro done for this section, this PR can close out #12629, too 👍 |
|
@HKuz awesome, thanks! Was actually going to go look and see if you had opened one for this section. Perfect! I just added that to the PR text |
|
Ok, consulted w/ @bonham000 and made just a few more edits. @bonham000 if you want to take a look at this PR, let me know what you think. Based on @dhcodes & @raisedadead's suggestion I've modified to add an intro challenge to each section. For the object section, I pulled the intro material from the first 2 challenges. I don't think this compromises the integrity of either challenge as I repeated the info much more succinctly there. |
d88c958 to
8447a3e
Compare
|
@raisedadead Same question on this one - once #12720 is merged, will I need to rebase and force update this branch for the all of these changes to merge smoothly? Thanks! You've been a huge help to me lately |
|
Yes, @no-stack-dub-sack and on that note may be the other PR #12720 can be taken up later. In which case we should merge this in and rebase that, which we are going to do in any case as it has conflicts. Thanks and happy to help! |
dhcodes
left a comment
There was a problem hiding this comment.
Some wording fixes and other additions.
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
8447a3e to
ae47e73
Compare
|
@dhcodes ok, so I made all the changes you mentioned except for one - see last "outdated" comment above. So I think this should be good. And, you pointing out a few typos gave me a strong hunch that there would be more, so I spellchecked the whole thing and caught several additional typos. If you and @raisedadead are ok with all of this, I think this section should be in pretty sound shape! |
✨ ✨ LGTM. ✨ ✨Thanks @no-stack-dub-sack @dhcodes please have a look and merge. |
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
ae47e73 to
a34ea93
Compare
|
@dhcodes haha, no worries, nice catch yet again, better to get this right! All set |
a34ea93 to
83dca62
Compare
|
LGTM 👍 💯 🌮 Thanks for all the changes. |
Pre-Submission Checklist
stagingbranch of freeCodeCamp.fix/,feature/, ortranslate/(e.g.fix/signin-issue)npm test. Usegit commit --amendto amend any fixes.Type of Change
Checklist:
Description
This is just a quick PR to update the copy for the Array section of the basic data structure challenges. I've been working through these for the last few days, and one thing I noticed is that the Object challenges gave a bit better of an overview on objects as data structures, so just wanted to match the tone and scope of that conversation (given the topic of the section) to make sure the array intro was just as thorough and complete.