-
-
Notifications
You must be signed in to change notification settings - Fork 44.5k
Discuss Refactoring of API in Client #39590
Copy link
Copy link
Closed
Labels
platform: apiServer application that needs familiarity with Express, Fastify, MongoDB etc.Server application that needs familiarity with Express, Fastify, MongoDB etc.scope: tools/scriptsScripts for supporting dev work, generating config and build artifacts, etc.Scripts for supporting dev work, generating config and build artifacts, etc.status: discussingUnder discussion threads. Closed as stale after 60 days of inactivity.Under discussion threads. Closed as stale after 60 days of inactivity.
Metadata
Metadata
Assignees
Labels
platform: apiServer application that needs familiarity with Express, Fastify, MongoDB etc.Server application that needs familiarity with Express, Fastify, MongoDB etc.scope: tools/scriptsScripts for supporting dev work, generating config and build artifacts, etc.Scripts for supporting dev work, generating config and build artifacts, etc.status: discussingUnder discussion threads. Closed as stale after 60 days of inactivity.Under discussion threads. Closed as stale after 60 days of inactivity.
This comes about as I was going to refactor
Certification.jsto not rely on hardcoded values, but after discussing with Mrugesh and Oliver, realise it is not a quick section to fix.Top sections to refactor:
./reduxMove from using both epics and sagas to just sagas.What I have been looking into:
Certification.js(certMapSelector, and renderLegacyFullStack)ShowCertification.js(importscertMap)certAndProjectMap.js(Kris left a comment about refactoring to automatically generate from md/.json files)getChallenges.js(Oliver mentioned splitting this up into more bite-sized functions to allow better access outwith)Minutes:
certAndProjectMap.jsis likely to be deletedcertMapandprojectMapshould be fetched with useStaticQuery when we build the clientCertification.jsandShowCertification.jscould make use of a graphQL query to fetch thecertMapFeel free to edit this. @ojeytonwilliams and @raisedadead feel free to correct/add anything I missed.