Skip to content

fix(dashboard): show confirm dialog and delete pages and folder#483

Merged
surajshetty3416 merged 3 commits intofrappe:developfrom
aditorito:fix/dashboard-delete-confirm-not-showing
Feb 7, 2026
Merged

fix(dashboard): show confirm dialog and delete pages and folder#483
surajshetty3416 merged 3 commits intofrappe:developfrom
aditorito:fix/dashboard-delete-confirm-not-showing

Conversation

@aditorito
Copy link
Copy Markdown
Contributor

@aditorito aditorito commented Feb 6, 2026

Fix #481

Change

  • Fixed delete actions not responding due to confirmation dialog not rendering.
  • Root cause was usage of confirmDialog from frappe-ui, which is not mounted in the Builder app.
  • Reworked confirm() to use the Builder’s existing dialog system instead.
  • This ensures confirmation dialogs render correctly and delete flows complete as expected.

Notes

  • Now the Delete button is working for both Pages and folder
Screen.Recording.2026-02-06.181749.mp4

@codecov
Copy link
Copy Markdown

codecov bot commented Feb 6, 2026 •
edited
Loading

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 60.61%. Comparing base (ef7bfe2) to head (1038d5b).
⚠️ Report is 141 commits behind head on develop.

Additional details and impacted files 
@@           Coverage Diff            @@
##           develop     #483   +/-   ##
========================================
  Coverage    60.61%   60.61%           
========================================
  Files           28       28           
  Lines         2722     2722           
========================================
  Hits          1650     1650           
  Misses        1072     1072

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@surajshetty3416 surajshetty3416 merged commit dc2470b into frappe:develop Feb 7, 2026
3 checks passed
@github-actions
Copy link
Copy Markdown

github-actions bot commented Mar 29, 2026

🎉 This PR is included in version 1.23.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@surajshetty3416 surajshetty3416 surajshetty3416 approved these changes

Assignees

No one assigned

Labels

released

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Delete action does nothing on Dashboard (Confirm dialog never appears)

2 participants

@aditorito @surajshetty3416