-
Notifications
You must be signed in to change notification settings - Fork 430
Delete action does nothing on Dashboard (Confirm dialog never appears) #481
Copy link
Copy link
Closed
Labels
Description
Description
While using the Dashboard (All Pages view) in Builder, I noticed that the Delete action from the dropdown does nothing.
1.When clicking Delete on a page or folder:
- No confirmation dialog appears
- The item is not deleted
- The action silently stops, making it feel broken
This happens consistently and is easy to reproduce on the current develop branch
Screen.Recording.2026-02-06.010209.mp4
Root Cause
The delete flow relies on a confirm() helper that internally uses confirmDialog from frappe-ui.
However, Builder does not mount or use Frappe UI’s dialog system.
As a result:
confirmDialog() has no dialog host to render into
Vue silently renders nothing
The returned promise never resolves
Execution stops before the delete API is called
In short, the delete logic is calling a dialog system that isn’t part of the app’s render tree.
Proposed Solution
- Avoid using confirmDialog from frappe-ui for delete actions in Builder.
- Re-implement confirm() using Builder’s existing dialog system
(builderStore.appDialogs / Dialog.vue)
Reactions are currently unavailable