Skip to content

fix: opening other dialogs/popovers did not hide draggable popup#456

Merged
surajshetty3416 merged 1 commit intofrappe:developfrom
stravo1:fix-draggable-popup-visibility
Jan 8, 2026
Merged

fix: opening other dialogs/popovers did not hide draggable popup#456
surajshetty3416 merged 1 commit intofrappe:developfrom
stravo1:fix-draggable-popup-visibility

Conversation

@stravo1
Copy link
Copy Markdown
Member

@stravo1 stravo1 commented Dec 28, 2025

Before:

Screen.Recording.2025-12-28.at.10.24.41.PM.mov

Fix:

Screen.Recording.2025-12-28.at.10.24.13.PM.mov

@codecov
Copy link
Copy Markdown

codecov bot commented Dec 28, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 49.26%. Comparing base (858cf28) to head (d21c426).
⚠️ Report is 67 commits behind head on develop.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop     #456   +/-   ##
========================================
  Coverage    49.26%   49.26%           
========================================
  Files           28       28           
  Lines         2176     2176           
========================================
  Hits          1072     1072           
  Misses        1104     1104           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@surajshetty3416 surajshetty3416 merged commit 94bd549 into frappe:develop Jan 8, 2026
5 of 6 checks passed
surajshetty3416 added a commit that referenced this pull request Jan 11, 2026
surajshetty3416 added a commit that referenced this pull request Jan 11, 2026
So that it does not always stays on top when modal appears because modal gets appended to the body and it should always be on top and not the popup

#456 this fix worked but it completely hides popup till the modal is open which creates unnecessary UI flashes and causes confusion
@surajshetty3416 surajshetty3416 mentioned this pull request Jan 11, 2026
@github-actions
Copy link
Copy Markdown

🎉 This PR is included in version 1.22.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants