Add CredentialProvider to standalone console#10343
Conversation
|
Don't forget the backport to 9.4.1 |
|
Be aware that the fatjar version of the credentialprovider need to be added as a dependancy together with the fatjar version of the frankframework-kubernetes. So that the container image of the standalone frank-console(frankframework-docker-embedded) in K8s is able to use the K8s secret manager to fetch there authAliases |
60d9085 to
5780fc2
Compare
6356b04 to
e5cd29b
Compare
console/war/src/main/java/org/frankframework/console/runner/DirectoryClassLoader.java
Fixed
Show fixed
Hide fixed
console/war/src/main/java/org/frankframework/console/runner/DirectoryClassLoader.java
Fixed
Show fixed
Hide fixed
console/war/src/main/java/org/frankframework/console/runner/DirectoryClassLoader.java
Fixed
Show fixed
Hide fixed
| * Implementations of this class should use {@link DirectoryClassLoader#getLocalResource(String)} | ||
| */ | ||
| @Override | ||
| public final URL getResource(String name) { |
There was a problem hiding this comment.
I suggest to start adding Nullable / NonNull annotations wherever applicable, and perhaps see if a class can be @NullMarked.
| public final URL getResource(String name) { | |
| @Nullable | |
| public final URL getResource(@Nullable String name) { |
|
|
||
| private CredentialConstants() { | ||
| super(CredentialConstants.class.getClassLoader(), APP_CONSTANTS_PROPERTIES_FILE); | ||
| super(Thread.currentThread().getContextClassLoader(), APP_CONSTANTS_PROPERTIES_FILE); |
There was a problem hiding this comment.
Didn't know any better way :(
| client = new KubernetesClientBuilder() | ||
| .editOrNewConfig() | ||
| .withConnectionTimeout(3_000) | ||
| .withRequestTimeout(3_000) | ||
| .withRequestRetryBackoffLimit(0) | ||
| .endConfig() | ||
| .build(); |
There was a problem hiding this comment.
We'll have to backport this, the default timeout is > 60 seconds...
|
| app.setSources(Set.of("SpringBootContext.xml")); | ||
| app.addPrimarySources(List.of(WsSciWrapper.class)); | ||
|
|
||
| // Custom ClassLoader to ensure we can read from the classpath as well as the far-jar. |
There was a problem hiding this comment.
| // Custom ClassLoader to ensure we can read from the classpath as well as the far-jar. | |
| // Custom ClassLoader to ensure we can read from the classpath as well as files next to the fat-jar. |
console/war/src/main/java/org/frankframework/console/runner/ConsoleStandaloneInitializer.java
Outdated
Show resolved
Hide resolved
(cherry picked from commit 7cae47a)
No description provided.