Allow Enum types in Messages, fix cast of Message to Enum#10279
Merged
Allow Enum types in Messages, fix cast of Message to Enum#10279
Conversation
|
nielsm5
approved these changes
Jan 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
I'm not sure about this change. The change in Message breaks getting the ExitState enum out of the session, in some tests. And possibly that is not just the unit-tests that are broken. So it kinda makes necessary some more complicated changes in PipeLineSession -- Changes that looked good at first but then started to doubt more and more before the change in Message made them necessary.
@nielsm5, what do you think about it?
Pull Request Checklist
Title
Issues
Message#asString()#10244Backports
Documentation
Tests
Breaking changes