Introduce recursionFilter and maxRecursion attributes in LdapFindGroupMembershipsPipe#10162
Merged
nielsm5 merged 1 commit intorelease/9.0from Dec 17, 2025
Merged
Conversation
…pMembershipsPipe (Based on changes made by Laurens Mäkel)
|
evandongen
approved these changes
Dec 16, 2025
nielsm5
approved these changes
Dec 17, 2025
10 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Introduce recursionFilter and maxRecursion attributes in LdapFindGroupMembershipsPipe.
(Based on changes made by Laurens Mäkel)
There are no tests for the LDAP Client and although it would be good to have real tests, for now I think this is beyond the scope of this code -- I think we should ask NN to test these changes in 9.0, which is why I made a 9.0 version first.
Pull Request Checklist
Title
Issues
Backports
Documentation
Tests
Breaking changes