Skip to content

Create test that uses scenario.resolveProperties#10153

Merged
nielsm5 merged 2 commits intorelease/9.3from
9.3/create-test-to-prove-resolveProperties-breaks-xslt
Dec 16, 2025
Merged

Create test that uses scenario.resolveProperties#10153
nielsm5 merged 2 commits intorelease/9.3from
9.3/create-test-to-prove-resolveProperties-breaks-xslt

Conversation

@nielsm5
Copy link
Member

@nielsm5 nielsm5 commented Dec 13, 2025

Setting scenario.resolveProperties=false to true will break this test.

Why?

@nielsm5 nielsm5 linked an issue Dec 13, 2025 that may be closed by this pull request
@tnleeuw
Copy link
Contributor

tnleeuw commented Dec 15, 2025

Setting scenario.resolveProperties=false to true will break this test.

Why?

Because in your input-file for one of the steps there is:

${extraElementen:kvkNummer} which is meant to be resolved by the Json2Xml pipe (or perhaps another pipe, I didn't check the pipeline yet) however it is now resolved by Larva.

Larva has this feature to put things like the host & port in input files, which it needs for some tests (from top of my head, I think API Listener Larva tests need that).

@MLenterman
Copy link

MLenterman commented Dec 15, 2025

Setting scenario.resolveProperties=false to true will break this test.
Why?

Because in your input-file for one of the steps there is:

${extraElementen:kvkNummer} which is meant to be resolved by the Json2Xml pipe (or perhaps another pipe, I didn't check the pipeline yet) however it is now resolved by Larva.

Larva has this feature to put things like the host & port in input files, which it needs for some tests (from top of my head, I think API Listener Larva tests need that).

In Zaakbrug we have translation profiles(configurable by user via a json file) for configuring custom mappings. With ${extraElementen:kvkNummer} you tell ZaakBrug to dynamically replace a certain element's value with the value of extraElementen element where name="kvkNummer" from the input message. It happens to use the same syntax as used for properties, but it has absolutely nothing to do with it. There are XSLT's for handling this syntax.

@tnleeuw
Copy link
Contributor

tnleeuw commented Dec 15, 2025

Setting scenario.resolveProperties=false to true will break this test.
Why?

Because in your input-file for one of the steps there is:
${extraElementen:kvkNummer} which is meant to be resolved by the Json2Xml pipe (or perhaps another pipe, I didn't check the pipeline yet) however it is now resolved by Larva.
Larva has this feature to put things like the host & port in input files, which it needs for some tests (from top of my head, I think API Listener Larva tests need that).

In Zaakbrug we have translation profiles(configurable by user via a json file) for configuring custom mappings. With ${extraElementen:kvkNummer} you tell ZaakBrug to dynamically replace a certain element's value with the value of extraElementen element where name="kvkNummer" from the input message. It happens to use the same syntax as used for properties, but it has absolutely nothing to do with it. There are XSLT's for handling this syntax.

Yes, so unfortunately a change that was made in 9.2 or 9.3 (don't remember on top of my head which version) broke this out-of-the-box for your use-cases and this Larva setting needs to be changed in the scenarios.

We could consider making a global default so that this can be toggled for all scenarios at once.

If you have a common properties file shared between all tests, you can set this property

scenario.resolveProperties=false

once in this shared properties file to disable it for all your Larva tests.

@nielsm5 nielsm5 changed the title Fix scenario.resolveProperties Create test that uses scenario.resolveProperties Dec 15, 2025
Co-authored-by: Tim van der Leeuw <tnleeuw@gmail.com>
@nielsm5 nielsm5 merged commit ebc4796 into release/9.3 Dec 16, 2025
8 of 9 checks passed
@nielsm5 nielsm5 deleted the 9.3/create-test-to-prove-resolveProperties-breaks-xslt branch December 16, 2025 15:58
nielsm5 added a commit that referenced this pull request Dec 16, 2025
@sonarqubecloud
Copy link

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Xslt 3.0 larva tests break in newer versions

3 participants