Make getSocket{Family}TCP try all addr candidates#32
Merged
snoyberg merged 1 commit intofpco:masterfrom May 11, 2016
Merged
Conversation
Fixes fpco#31. Some hostnames can resolve to more than one address. A common example is "localhost", that on many (but not all) platforms resolves to 127.0.0.1 (ipv4) and ::1 (ipv6). When one uses `getaddrinfo` in such address, and doesn't specify if one is looking for an ipv4 or ipv6 address (e.g., because one doesn't know and/or don't care and wants to support both), one will get more than one result. The right way of handling this is trying to connect to each of the provided addresses, in order, one by one. However, in the previous implementation, a function such as runTCPClient would only attempt to use the first address. Two things two note: - One of the tests in Data.Streaming.NetworkSpec was using runTCPClient to connect to "127.0.0.1"; if one were to change that by "localhost", it would fail on Debian, OS X and others. - bindPortTCP (via bindPortGen) was already trying all given addresses until one succeeded.
Member
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #31.
Some hostnames can resolve to more than one address. A common example is "localhost", that on many (but not all) platforms resolves to
127.0.0.1(ipv4) and::1(ipv6). When one usesgetaddrinfoin such address, and doesn't specify if one is looking for an ipv4 or ipv6 address (e.g., because one doesn't know and/or don't care and wants to support both), one will get more than one result. The right way of handling this is trying to connect to each of the provided addresses, in order, one by one. However, in the previous implementation, a function such asrunTCPClientwould only attempt to use the first address.Two things two note:
Data.Streaming.NetworkSpecwas usingrunTCPClientto connect to"127.0.0.1"; if one were to change that by "localhost", it would fail on Debian, OS X and others.bindPortTCP(viabindPortGen) was already trying all given addresses until one succeeded.