Skip to content

Allow proxying to HTTPS servers.#15

Merged
snoyberg merged 2 commits intofpco:masterfrom
wagonhq:proxy-to-https
Nov 19, 2015
Merged

Allow proxying to HTTPS servers.#15
snoyberg merged 2 commits intofpco:masterfrom
wagonhq:proxy-to-https

Conversation

@benjamin-wagon
Copy link
Copy Markdown

This PR does not implement HTTPS requests when using rawProxyTo. Is this possible?

@gregwebs
Copy link
Copy Markdown

Also wondering if it is a bad idea to use http-proxy instead of http-reverse-proxy because it supports SSL?

@snoyberg
Copy link
Copy Markdown
Member

I'd rather do this in a way that doesn't break backwards compatibility with all users. How about adding a new constructors WPRProxyDestSecure instead?

@benjamin-wagon
Copy link
Copy Markdown
Author

That sounds super reasonable; solves the rawProxyTo issue as well!

I'll submit a follow-up commit tomorrow.
On Nov 18, 2015 00:17, "Michael Snoyman" notifications@github.com wrote:

I'd rather do this in a way that doesn't break backwards compatibility
with all users. How about adding a new constructors WPRProxyDestSecure
instead?


Reply to this email directly or view it on GitHub
#15 (comment)
.

@benjamin-wagon
Copy link
Copy Markdown
Author

Having both WPRProxyDestSecure and WPRModifiedRequestSecure feels a tiny bit icky, but I'm not seeing a better approach.

snoyberg added a commit that referenced this pull request Nov 19, 2015
Allow proxying to HTTPS servers.
@snoyberg snoyberg merged commit 9969352 into fpco:master Nov 19, 2015
@snoyberg
Copy link
Copy Markdown
Member

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants