Fix forest brawl error console: "Trying to check if client is synced from another client!"#311
Closed
TheYellowArchitect wants to merge 9 commits intofoxssake:mainfrom
Closed
Conversation
…piler hits error if function doesnt exist, so typos are caught with static RPC functions)
"Trying to check if client is synced from another client!"
elementbound
reviewed
Nov 8, 2024
| avatar.visible = false | ||
| while not NetworkTime.is_client_synced(id): | ||
| await NetworkTime.after_client_sync | ||
| if (multiplayer.is_server()): |
Contributor
There was a problem hiding this comment.
This would only hide the avatar on the server, but not for other clients.
Contributor
|
Now that you raise this, I think we could open up this functionality to all clients, i.e. any client would be able to query who's synced and who's not. That way the gameplay code could stay as-is, the functionality would work well, and we'd get an extra (minor) feature 🙂 |
Contributor
|
Closing in favor of #325, which also removes this error log. |
elementbound
added a commit
that referenced
this pull request
Nov 11, 2024
Makes peer sync success public, so now every peer can check whether another peer has completed their time sync handshake. Supersedes #311
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For as long I have been using netfox, there is a harmless console output, but it is annoying because it is an error and is the only error in the console:
This adds a simple if check. Because the signal
after_client_syncis emitted only at the server via this RPCSo that if check ends up in the same data flow but without printing an error.