Set record input props for all players, not just authority#309
Set record input props for all players, not just authority#309TheYellowArchitect wants to merge 9 commits intofoxssake:mainfrom
Conversation
…piler hits error if function doesnt exist, so typos are caught with static RPC functions)
It absolutely should care about authority. The variables We record all state properties all the time, because even if we don't own those properties, we still need a history to rewind to. This is in contrast to inputs, where we don't record anything we don't own, but instead wait for those properties to arrive from the owner. This is why So imo the better call would either to remove
You're talking about a private property, so even with this PR there wouldn't be a supported way to get input property entries. You can still grab the property names either way.
False, see first half of my comment. |
|
Done in #320 |
|
|
Solves #250
Basically registers the properties in that variable. Otherwise, it is always the same as
_auth_input_propsand made obsolete by it. But it shouldn't be so, because_record_input_propsshouldn't care about authority, just like_record_state_propsdoesn't care about authority.Currently, without this PR, there is no way to get the input property entries of a
RollbackSynchronizerwhose authority we don't have. Which is illogical given we know them viaNot to mention that this variable (
_record_input_props) currently exists, but is completely unused (it cannot be used without this anyway)