fix: TickInterpolator glitch on state switch#301
Merged
elementbound merged 1 commit intomainfrom Oct 15, 2024
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
At the end of the tick loop,
TickInterpolatorcatches the new state and starts interpolating towards it. However, betweenNetworkTime.after_tick_loopand the nextTickInterpolator._processcallback, there may be a single frame where the interpolated node(s) are still in the target state, and then get set back to the starting state once the interpolation kicks in. This leads to a periodic glitching.To fix this,
TickInterpolatoralways applies the starting state once it's captured, inNetworkTime.after_tick_loop.Closes #287