Fixed NetworkPopup.tscn UI so the buttons host and join are always visible#285
Conversation
…piler hits error if function doesnt exist, so typos are caught with static RPC functions)
|
Since only the example project is modified in this PR, the version bumps for the netfox libraries aren't necessary. |
reverted 1 version bump
reverted 1 version bump
reverted 1 version bump
reverted 1 version bump
|
Thanks for working on this! The way I understand, the current changes are to shrink the UI. Would it be possible to have the panel have a max size ( i.e. no bigger than 540x540 ), but shrink if the window gets smaller, and keep it centered? Let me know if you'd like to work on this, otherwise I can mess around with it too. |
|
It would need custom code to scale down, as the Control property works via anchors, doesn't have a Scale property like As for implementing the suggestion, not worth the time imo. This PR took 5 minutes. Gathering the images and doing the git push took more time than making this. I would recommend just merging this and using the saved time for netcoding PRs, instead of UI which anyone can do with trial&error |
|
I can take a look at making the window scaleable if it's alright with you all. |
|
@annamaria-szentpeteri please feel free! |
|
I just realized that this Anyway, this PR is exclusively for these 2 examples |
|
Happened to stumble into a video which explains scaling |
|
Added a custom minimum size and centered the panel, so it will be visible in many more cases. |
(Literally the 2 inspector changes in #240 but without that whole 4.3 baggage, reposting images below)
Before

After

Below is on the scene itself, before:

After (noray was taken in mind)


Ideally, host/join would be on the bottom of the panel, but I would have to make a new Control node, and that would be too much for sth like this