Fixed NetworkPopup.tscn UI so the buttons host and join are always visible#240
Closed
TheYellowArchitect wants to merge 1 commit intofoxssake:mainfrom
Closed
Fixed NetworkPopup.tscn UI so the buttons host and join are always visible#240TheYellowArchitect wants to merge 1 commit intofoxssake:mainfrom
TheYellowArchitect wants to merge 1 commit intofoxssake:mainfrom
Conversation
Contributor
|
Ideally I wouldn't wait for a 4.3 upgrade to merge this 😄 Why not just open the project in Godot 4.1? GodotManager and godots are really good tools for managing multiple Godot versions. Anyway, if you can either change this PR so that it doesn't contain the import changes, or explain what changed so I can apply them myself, I'd be happy to merge. |
Contributor
Author
It's a minor/negligent PR, and I am working on my project atm (using netfox) 😅 |
Contributor
Author
|
Closing in favour of #285 (it has the same end result as this) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before
After
Below is on the scene itself, before:
After (noray was taken in mind)
Ideally, host/join would be on the bottom of the panel, but I would have to make a new Control node, and that would be too much for sth like this
NOTE: There are many line additions because of default 4.3 import -_-
So probably merge after netfox upgrades to 4.3