fix: Problems with multiplayer-netfox example#135
Merged
elementbound merged 6 commits intofoxssake:mainfrom Nov 25, 2023
zibetnu:fix/multiplayer-netfox
Merged
fix: Problems with multiplayer-netfox example#135elementbound merged 6 commits intofoxssake:mainfrom zibetnu:fix/multiplayer-netfox
elementbound merged 6 commits intofoxssake:mainfrom
zibetnu:fix/multiplayer-netfox
Conversation
Contributor
elementbound
left a comment
There was a problem hiding this comment.
Thanks for the PR @zibetnu! I've suggested some changes, which I'm happy to implement myself. Let me know if you'd like to tackle the updates :)
If not, I can either open a new PR based on your changes, or update your fork if you give me write permission.
Contributor
Author
|
Done! I decided to make those changes myself because I'm trying to familiarize myself with netfox anyway. I also invited you to have write access. Please let me know if there was a better way to do that. |
zibetnu
commented
Nov 25, 2023
elementbound
approved these changes
Nov 25, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I ran into three issues when taking a look at the netfox example.
First, the connect_ui issue mentioned in #134 showed up here as well. I applied the same fix.
Second, I noticed that the player's
_tickfunction wasn't getting called. It looks like it should be connected toNetworkTime'son_ticksignal, so I went ahead and did that as a fix.Third, I can't get the players to move and haven't figured out why. The input works and
velocityis set, but nothing noticeable happens whenmove_and_slideis called. Hopefully you'll know what needs to be done to fix this, and then the fix can be part of this or a different pull request.Oh also, Godot automatically removed a line from
player.tscnand I thought it was relevant enough to be part of this pull request.