fix: Problems with multiplayer-simple example#134
Merged
elementbound merged 2 commits intofoxssake:mainfrom Nov 25, 2023
zibetnu:fix/multiplayer-simple
Merged
fix: Problems with multiplayer-simple example#134elementbound merged 2 commits intofoxssake:mainfrom zibetnu:fix/multiplayer-simple
elementbound merged 2 commits intofoxssake:mainfrom
zibetnu:fix/multiplayer-simple
Conversation
This was referenced Nov 24, 2023
elementbound
approved these changes
Nov 25, 2023
Contributor
elementbound
left a comment
There was a problem hiding this comment.
Thank you for the PR, lgtm!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I ran into two issues when taking a look at the simple example.
First, connect_ui wasn't set in either of the bootstrappers:
Second, players would fly away when spawning inside each other. I can sometimes get them to fall down again by moving them around, but I didn't manage to make that work in the video showcasing the issue:
players-fly.mp4
This pull request fixes both issues by setting connect_ui and making it so players don't collide with each other. You can see the fixes in action here:
working.mp4