Respect "respectful" for where keyword in module header#245
Merged
brandonchinn178 merged 5 commits intomainfrom Nov 8, 2022
Merged
Respect "respectful" for where keyword in module header#245brandonchinn178 merged 5 commits intomainfrom
brandonchinn178 merged 5 commits intomainfrom
Conversation
|
👋 @brandonchinn178 Reviewer: Please verify the following things have been done, if applicable.
|
85f9558 to
7cb799f
Compare
This was referenced Oct 30, 2022
7cb799f to
a951b3e
Compare
georgefst
approved these changes
Nov 8, 2022
| -- [AnnModule, AnnWhere] or [AnnSignature, AnnWhere] | ||
| [AddEpAnn _ moduleLoc, AddEpAnn AnnWhere whereLoc] -> | ||
| (epaLocationRealSrcSpan moduleLoc, epaLocationRealSrcSpan whereLoc) | ||
| anns -> error $ "Module had unexpected annotations: " ++ showSDocUnsafe (ppr anns) |
Collaborator
There was a problem hiding this comment.
Maybe it's just too long since I've contributed any significant code, but do we generally use error? I assumed the main monad stack had some facility for raising pure errors.
Collaborator
Author
There was a problem hiding this comment.
For impure errors? Not that I can tell. There's an existing use of error already, at least:
Line 109 in db6755a
Co-authored-by: George Thomas <georgefsthomas@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #167
Blocked by #244