Improve formatting of export list with module warning#244
Merged
brandonchinn178 merged 3 commits intomainfrom Nov 7, 2022
Merged
Improve formatting of export list with module warning#244brandonchinn178 merged 3 commits intomainfrom
brandonchinn178 merged 3 commits intomainfrom
Conversation
|
👋 @brandonchinn178 Reviewer: Please verify the following things have been done, if applicable.
|
1a0bfee to
d8f2285
Compare
d8f2285 to
b368632
Compare
b368632 to
1d5c1d6
Compare
Collaborator
|
Looks good, but I'm struggling to work out why the commits here are split up as they are. Presumably commit 3 is the implementation that causes the output changes in commit 2? So why aren't they squashed together? |
Collaborator
Author
|
ah I was doing TDD, so I fixed the output first to get a test failure, then I just had to experiment in the third commit to make it pass. I can squash them now if you want |
Collaborator
|
Fair enough. It's not my preferred approach but I don't really care. |
georgefst
approved these changes
Nov 7, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Trying to align closer to what Ormolu does here, which should also help with #167
Blocks #245