Use import export comma option in commaDel'#187
Merged
brandonchinn178 merged 2 commits intofourmolu:mainfrom May 30, 2022
3kyro:174-fix-ie-inconsistent-formatting
Merged
Use import export comma option in commaDel'#187brandonchinn178 merged 2 commits intofourmolu:mainfrom 3kyro:174-fix-ie-inconsistent-formatting
brandonchinn178 merged 2 commits intofourmolu:mainfrom
3kyro:174-fix-ie-inconsistent-formatting
Conversation
Collaborator
|
Thanks! I'm on vacation right now, so I'll review + merge when I get back |
brandonchinn178
approved these changes
May 29, 2022
Collaborator
brandonchinn178
left a comment
There was a problem hiding this comment.
Looks great, thanks! Left a comment; feel free to incorporate it or resolve it as "wont do", and I'll merge after.
Now to figure out why CI isn't running on here...
Comment on lines
+183
to
+186
| commaDel' = | ||
| getPrinterOpt poImportExportCommaStyle >>= \case | ||
| Leading -> breakpoint' >> comma >> space | ||
| Trailing -> comma >> breakpoint |
Collaborator
There was a problem hiding this comment.
It'd be nice to unify this with the version in Ormolu.Printer.Combinators. What do you think about moving commaDel' into Ormolu.Printer.Combinators and defining
commaDel = commaDel' poCommaStyle
commaDelImportExport = commaDel' poImportExportCommaStyle?
Contributor
Author
There was a problem hiding this comment.
Thanks, I've added commaDelImportExport as you suggest.
Collaborator
|
Ok sorry, just fixed CI on |
4 tasks
Collaborator
|
Awesome, thanks!! |
brandonchinn178
added a commit
that referenced
this pull request
May 30, 2022
brandonchinn178
added a commit
that referenced
this pull request
May 30, 2022
Update changelog for #187
Contributor
Author
|
I've just realized I misplaced |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
commaDel'now checks the import export lists comma option. This makes nested list imports being formatted similarly to regular lists.fixes #174
cc @brandonchinn178