Skip to content

Do hang record constructors when turned on setting#103

Open
s-and-witch wants to merge 3 commits intofourmolu:mainfrom
s-and-witch:master
Open

Do hang record constructors when turned on setting#103
s-and-witch wants to merge 3 commits intofourmolu:mainfrom
s-and-witch:master

Conversation

@s-and-witch
Copy link

Hi, all! I hear that you want more options in your formatter, so I added shutdown of this (tweag/ormolu@1eb3f1c) PR as new option.

@pepeiborra pepeiborra mentioned this pull request Sep 22, 2021
@georgefst georgefst mentioned this pull request Oct 30, 2021
@brandonchinn178 brandonchinn178 added the new config option Adds or would add new configuration option label Jan 24, 2022
@brandonchinn178 brandonchinn178 force-pushed the master branch 12 times, most recently from c7364ed to 40bcc74 Compare May 18, 2022 21:03
@brandonchinn178
Copy link
Collaborator

brandonchinn178 commented Jun 1, 2022

👋 @Player-205
Thank you for opening this PR and being patient while we sorted out how to handle all the new contributions for new configuration options!

If you haven't noticed, we finally merged in a new testing framework for configuration options (#169)! This means we can finally address the backlog of open PRs.

Please do the following steps

  • Rebase against main

    git remote add upstream git@github.com:fourmolu/fourmolu
    git fetch upstream
    git rebase -i upstream/main
  • Resolve merge conflicts

  • Ensure a file has been added to changelog.d/ (see changelog.d/README.md)

  • Ensure configuration docs in README.md have been updated

  • Ensure fourmolu.yaml updated to stay in sync with config in README.md

  • Ensure tests have been added

You can use #135 as a reference for this checklist.

@s-and-witch
Copy link
Author

@brandonchinn178
Just making sure I'm in touch. I'll do it when I have free time. Unfortunately, now it is categorically lacking.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

new config option Adds or would add new configuration option

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants