feat(cheatcodes): vm.rememberKeys#9087
Merged
Merged
Conversation
zerosnacks
reviewed
Oct 10, 2024
Contributor
Author
|
Companion PR: foundry-rs/forge-std#622 |
ArkFunds
approved these changes
Oct 10, 2024
Contributor
Author
|
@grandizzy @klkvr review pls |
klkvr
approved these changes
Oct 11, 2024
klkvr
left a comment
Member
There was a problem hiding this comment.
lgtm, note on performance, would like us to revisit script wallets handling if we want to support scripting cheats in tests as well
| // This is needed in case of testing scripts, wherein script wallets are not set on setup. | ||
| let script_wallets = ScriptWallets::new(MultiWallet::default(), None); | ||
| script_wallets.add_local_signer(wallet); | ||
| Arc::make_mut(&mut state.config).script_wallets = Some(script_wallets); |
Member
There was a problem hiding this comment.
this might be quite expensive because we'll clone config which stores all project bytecodes
I think essentially for tests ScriptWallets can just be a vec of PrivateKeySigners stored on Cheatcodes
rplusq
pushed a commit
to rplusq/foundry
that referenced
this pull request
Nov 29, 2024
* feat(`cheatcodes`): vm.rememberKeys * docs + return addresses + test * remeberKeys with language * doc nits * cargo cheats * set script wallet in config if unset * nit * test
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Closes #8225 + Closes #7950
Solution
Introduces cheatcodes to derive and save multiple wallets/signers in the script env.
Under the hood these cheatcodes save the derived wallets in
ScriptWalletssuch that they are persisted throughout the script environment.Moreover, to aid in the testing of scripts (as in
forge test DeployScript.t.sol) these cheatcodes will initializeScriptWalletsin theCheatsConfigif not already initializedThis is particularly useful for testing scripts that require unlocked accounts.