fix(anvil): clean up eth_estimateGas#7515
Merged
Merged
Conversation
mattsse
requested changes
Mar 28, 2024
mattsse
left a comment
Member
There was a problem hiding this comment.
this is great!
only have a few suggestions
ZhangZhuoSJTU
pushed a commit
to MEDGA-eth/foundry
that referenced
this pull request
Mar 29, 2024
* fix(anvil): clean up eth_estimateGas * fix doc * fix doc * fix doc * review fixes
2 tasks
This was referenced Apr 26, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Closes #7490 and changes code to avoid duplication of error handling logic between initial estimation vs binary search steps.
Solution
Adds
GasEstimationCallResultwhich takes care of matching errors occured during call and fully covers all potentialInstructionResults to distinguish between out of gas errors, reverts and unexpected failures.