perf: use jemalloc as the global allocator on unix (try 2)#7448
Merged
Conversation
Member
this is not strictly true. where do we depend on the page size? also: "The architecture allows up to 4 levels of translation tables with a 4KB page size and up to 3 levels with a 64KB page size." (4kb 4 layers is the same as x86) https://docs.kernel.org/arch/arm64/memory.html |
36f1719 to
158e55c
Compare
Member
Author
|
I don't know, I just know that aarch64 mostly breaks if we enable jemalloc on it, as per many reth issues and the linked issue |
Member
this is a special case for reth because we exhaust the virtual address space on some arm architectures, this should not be the case for foundry |
Member
Author
|
It's not about exhausting any address space, it straight up just does not work, see |
onbjerg
approved these changes
Mar 27, 2024
ZhangZhuoSJTU
pushed a commit
to MEDGA-eth/foundry
that referenced
this pull request
Mar 29, 2024
This was referenced Apr 26, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We should be able to enable this on unix and x64. Cannot enable on: