feat: change mui-series paused behavior for Safari support #97#107
Closed
ncoden wants to merge 5 commits intofoundation:masterfrom
Closed
feat: change mui-series paused behavior for Safari support #97#107ncoden wants to merge 5 commits intofoundation:masterfrom
ncoden wants to merge 5 commits intofoundation:masterfrom
Conversation
Do not set the animation name until it need to be played. This is the only way to control the animation start on all browsers (including latest Safari versions). See issue for more informations. **BREAKING CHANGE** When `.is-animating` is removed from `.mui-series`, the animation is now reset instead of paused. Setting `.is-animating` back will start the animation from its begining. Closes foundation#97
Allow to enforce the previous paused behavior with a "mui-pause" modifier on `mui-series` elements. See foundation#97
Contributor
Author
|
Poke @SassNinja @hugogiraudel for review. |
Contributor
|
Hello. It will have to wait for Monday for me to find time to review it. |
Contributor
Author
|
Thank you for your time @hugogiraudel. Please note that this PR has downsides. I hope you'll find a solution for #97 that does not break the pause behavior. |
Contributor
Author
|
Closing in favor of #107 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The previous and latest versions of macOS Safari do not handle correctly
animation-play-statewithanimation-fill-modeand the animation never start. See #97 for more informations.This PR allow the animation to run but also introduce breaking changes.
Changes
11dde5e Change mui-series behavior for better Safari support
Do not set the animation name until it need to be played. This is the only way to control the animation start on all browsers (including latest Safari versions). See issue for more informations.
efd6e38 Add "pause" mui-series modifier to rollback to pause behavior
Old behavior can be recoverd with the
.mui-pausemodifier290855e Update documentation about mui-series paused behavior and rollback
When
.is-animatingis removed from.mui-series, the animation is now reset instead of paused. Setting.is-animatingback will start the animation from its begining.Closes #97