hey @AdrianVollmer, thanks for this PR!!

been checking it and have only one doubt, related to the except ImportError when trying to import both importlib.resources and importlib.metadata
in which cases should it be needed to catch it? As since py3.7 and py3.8 they seem to be included in the standard library according to python docs
and if so, fallback lib should be included in the requirements file, right?

Good catch, we need to add importlib_resources to the requirements.txt. importlib_metadata is already a dependency of Flask, but it has been added in p3.8: https://docs.python.org/3/library/importlib.metadata.html#module-importlib.metadata

Since impacket seems to support python 3.8 and higher, I suppose we can remove the try-exception block in version.py.

importlib.resources in py<3.9 doesn't have files: https://docs.python.org/3/library/importlib.resources.html#importlib.resources.files

So if impacket wants to support py3.8, we need to catch that exception.

I'll push another commit. Let me know what you think.

(Minor remark: the requirements.txt seems unnecessary, as the dependencies are defined in setup.py.)

Thank you!

mm yeah, that's true. Will check with the other maintainers and update here later today (being py3.8 an already EoL version perhaps we wanna remove it for next impacket version - as matter of fact, unit tests are not being executed for py3.8)

Will let you know later, thanks!

hey, yes... we'll remove support for python 3.8 in the next release. We did it in the context of #1965 but didn't reflect this new req in the README (will update that now)

but, yes, I'd remove that exception catching there to simplify the code

Thanks!

Done! I can squash the commits if you prefer that

Thank you @AdrianVollmer, merging now!