Made brick, life and blackjack usable in sshd and ansipixels new/open callable more then once#206
Merged
Made brick, life and blackjack usable in sshd and ansipixels new/open callable more then once#206
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #206 +/- ##
==========================================
- Coverage 17.31% 17.22% -0.10%
==========================================
Files 23 26 +3
Lines 4308 4332 +24
==========================================
Hits 746 746
- Misses 3531 3555 +24
Partials 31 31 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
ldemailly
added a commit
to fortio/sshdtui
that referenced
this pull request
Nov 21, 2025
ldemailly
added a commit
to fortio/sshdtui
that referenced
this pull request
Nov 21, 2025
* Run brick and life with updated sshd hooks in ansipixels * Use current tag from fortio/terminal#206 * New repo name * lint fix and text * A few more logs of what action the user made
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR refactors the terminal games (life, brick, and blackjack) to make them usable within SSH server environments by extracting game logic into reusable cli packages. The changes also enhance ansipixels to support pre-configured terminal environments through a new SkipOpen flag and lazy Logger initialization.
Key Changes
- Restructured games by moving main logic to
clisub-packages, allowing game code to be invoked from external contexts like SSH servers - Added
SkipOpenflag and lazy Logger initialization inansipixelsto support pre-opened terminal environments - Made
DetectColorModeEnvfunction public to allow custom environment variable providers
Reviewed Changes
Copilot reviewed 9 out of 9 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| life/main.go | New entry point that delegates to cli.Main() |
| life/cli/life.go | Refactored from main package to cli, split into Main() for setup and RunGame() for game loop |
| brick/main.go | New entry point that delegates to cli.Main() |
| brick/cli/brick.go | Refactored from main package to cli, introduces BrickConfig struct and split Main()/Run() pattern |
| brick/cli/replay.go | Changed package from main to cli |
| blackjack/main.go | New entry point containing all setup logic and calling cli.Game.RunGame() |
| blackjack/cli/blackjack.go | Refactored from main package to cli, exposes Game struct with public fields and RunGame() method |
| blackjack/cli/blackjack_test.go | Updated package name and field references from private to public |
| ansipixels/ansipixels.go | Added SkipOpen flag, DetectColorModeEnv function, and moved Logger initialization to Open() with nil check |
Comments suppressed due to low confidence (1)
brick/cli/brick.go:377
- [nitpick] The
FPSfield inBrickConfigis declared but never used. It's not set inMain()and not accessed inRun(). Consider removing it or setting it to*fpsFlaginMain()if it's intended for future use.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
works with
deployed, test at