Skip to content

Fix godoc comments for stricter golangci-lint v2.5.0#80

Merged
ldemailly merged 2 commits intonoinfo_on_redirectfrom
copilot/sub-pr-79
Nov 10, 2025
Merged

Fix godoc comments for stricter golangci-lint v2.5.0#80
ldemailly merged 2 commits intonoinfo_on_redirectfrom
copilot/sub-pr-79

Conversation

Copy link
Copy Markdown
Contributor

Copilot AI commented Nov 10, 2025

The shared workflows now use golangci-lint v2.5.0 with stricter godoc rules, blocking the original PR.

Changes

  • Package comment: Start with "Package log" per godoc convention
  • Exported symbols: Prefix all godoc comments with symbol names (19 instances across ANSIColors, Colors, LevelToColor, LevelToText, Color, LevelToStrA, LevelToJSON, JSONStringLevelToLevel, EnvPrefix, and functions ColorLevelToStr, ResponseRecorder.Flush, NewStdLogger, SetLogLevelStr, TimeToTS, FErrf, Int, Attr)
  • Const declaration: Move EnvPrefix to separate const block to avoid iota mixing

Example fix:

// Before
// Mapping of log levels to color.
LevelToColor = []string{...}

// After  
// LevelToColor is the mapping of log levels to color.
LevelToColor = []string{...}

✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.

Co-authored-by: ldemailly <3664595+ldemailly@users.noreply.github.com>
Copilot AI changed the title [WIP] Fix godoc golint errors in codebase Fix godoc comments for stricter golangci-lint v2.5.0 Nov 10, 2025
Copilot AI requested a review from ldemailly November 10, 2025 04:43
@ldemailly ldemailly marked this pull request as ready for review November 10, 2025 04:45
@ldemailly ldemailly merged commit e186aff into noinfo_on_redirect Nov 10, 2025
ldemailly added a commit that referenced this pull request Nov 10, 2025
…orClientTools() unless loglevel is verbose (#79)

* When stderr is redirected to a file, don't spam Ignoring SetDefaultsForClientTools() unless loglevel is verbose

* Fix godoc comments for stricter golangci-lint v2.5.0 (#80)

* Initial plan

* Fix godoc lint errors for stricter linters

Co-authored-by: ldemailly <3664595+ldemailly@users.noreply.github.com>

---------

Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
Co-authored-by: ldemailly <3664595+ldemailly@users.noreply.github.com>

---------

Co-authored-by: Copilot <198982749+Copilot@users.noreply.github.com>
Co-authored-by: ldemailly <3664595+ldemailly@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants