Skip to content

fix(formatjs_cli): fix warnings#5841

Closed
longlho wants to merge 1 commit intomainfrom
01-05-fix_formatjs_cli_fix_warnings
Closed

fix(formatjs_cli): fix warnings#5841
longlho wants to merge 1 commit intomainfrom
01-05-fix_formatjs_cli_fix_warnings

Conversation

@longlho
Copy link
Member

@longlho longlho commented Jan 6, 2026

TL;DR

Bump formatjs_cli version from 0.1.0 to 0.1.1 and improve code formatting.

What changed?

  • Updated the version of formatjs_cli from 0.1.0 to 0.1.1 in both Cargo.toml and Cargo.lock
  • Improved code formatting in the extract.rs file:
    • Removed an unused import for serde_json::Value
    • Fixed line breaks and indentation for better readability
    • Properly formatted multi-line method chains
    • Improved formatting of test assertions

How to test?

  • Verify that the package builds correctly with the new version
  • Run the existing tests to ensure functionality remains intact

Why make this change?

This change prepares for a new release version of the formatjs_cli package and improves code quality through better formatting. The removal of unused imports and consistent formatting enhances maintainability.

@longlho longlho marked this pull request as ready for review January 6, 2026 02:28
Copy link
Member Author

longlho commented Jan 6, 2026


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • main - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has required the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@graphite-app
Copy link

graphite-app bot commented Jan 6, 2026

Merge activity

  • Jan 6, 2:31 AM UTC: longlho added this pull request to the Graphite merge queue.
  • Jan 6, 2:32 AM UTC: CI is running for this pull request on a draft pull request (#5842) due to your merge queue CI optimization settings.
  • Jan 6, 2:35 AM UTC: Merged by the Graphite merge queue via draft PR: #5842.

graphite-app bot pushed a commit that referenced this pull request Jan 6, 2026
### TL;DR

Bump formatjs_cli version from 0.1.0 to 0.1.1 and improve code formatting.

### What changed?

- Updated the version of `formatjs_cli` from 0.1.0 to 0.1.1 in both Cargo.toml and Cargo.lock
- Improved code formatting in the extract.rs file:
  - Removed an unused import for `serde_json::Value`
  - Fixed line breaks and indentation for better readability
  - Properly formatted multi-line method chains
  - Improved formatting of test assertions

### How to test?

- Verify that the package builds correctly with the new version
- Run the existing tests to ensure functionality remains intact

### Why make this change?

This change prepares for a new release version of the formatjs_cli package and improves code quality through better formatting. The removal of unused imports and consistent formatting enhances maintainability.
@graphite-app graphite-app bot closed this Jan 6, 2026
@graphite-app graphite-app bot deleted the 01-05-fix_formatjs_cli_fix_warnings branch January 6, 2026 02:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant