fix(formatjs_cli): sort key before serializing#5833
Closed
Conversation
Merge activity
|
graphite-app bot
pushed a commit
that referenced
this pull request
Jan 6, 2026
### TL;DR Switched to sorted message keys in formatjs_cli and refactored ID generation into a dedicated module. ### What changed? - Changed from `HashMap` to `BTreeMap` in compile and extract modules to ensure consistent, alphabetically sorted message keys in output files - Extracted ID generation logic into a new dedicated module `id_generator.rs` - Added comprehensive tests to verify sorting behavior and ID generation - Updated Bazel build files to include the new module ### How to test? 1. Run the formatjs CLI to extract or compile messages: ``` formatjs extract "src/**/*.tsx" --out-file messages.json formatjs compile messages.json --out-file compiled.json ``` 2. Verify that the output JSON files have keys sorted alphabetically 3. Test ID generation with different patterns: ``` formatjs extract "src/**/*.tsx" --out-file messages.json --id-interpolation-pattern "[sha512:contenthash:hex:8]" ``` ### Why make this change? - Sorted keys provide consistent, deterministic output files, making diffs more meaningful and easier to review - Sorted keys improve version control by reducing unnecessary changes when only message order differs - The dedicated ID generator module improves code organization and maintainability - Comprehensive tests ensure the sorting behavior works correctly across different formatters and output types
5a71a12 to
6013fc1
Compare
Member
Author
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has required the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TL;DR
Switched to sorted message keys in formatjs_cli and refactored ID generation into a dedicated module.
What changed?
HashMaptoBTreeMapin compile and extract modules to ensure consistent, alphabetically sorted message keys in output filesid_generator.rsHow to test?
Run the formatjs CLI to extract or compile messages:
Verify that the output JSON files have keys sorted alphabetically
Test ID generation with different patterns:
Why make this change?