fix(@formatjs/icu-messageformat-parser): fix flatten, fix #4202#5784
Closed
fix(@formatjs/icu-messageformat-parser): fix flatten, fix #4202#5784
Conversation
Member
Author
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has required the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
Merge activity
|
graphite-app bot
pushed a commit
that referenced
this pull request
Jan 2, 2026
### TL;DR
Fix handling of pound symbols (`#`) in nested plural messages by replacing them with explicit variable references to avoid ambiguity.
### What changed?
- Added a new `replacePoundWithArgument` function that transforms pound elements (`#`) into explicit number elements (`{variableName, number}`) when needed
- Modified the hoisting logic to detect when plural elements are followed by other plural/select elements
- When multiple plurals are present, the outer plural's pound symbols are replaced with explicit variable references
- Implemented the same fix in both TypeScript and Rust versions of the parser
### How to test?
The PR includes test cases that verify the correct behavior:
- Test with two plurals: `{topicCount, plural, one {# topic} other {# topics}} and {noteCount, plural, one {# note} other {# notes}}`
- Test with three plurals: `{a, plural, one {# a} other {# as}}, {b, plural, one {# b} other {# bs}}, and {c, plural, one {# c} other {# cs}}`
### Why make this change?
Fixes issue #4202 where nested plural messages with pound symbols (`#`) could be ambiguous. When multiple plurals are present in a message, the pound symbol in each plural should refer to its own variable. By replacing outer plural's pound symbols with explicit variable references, we ensure correct variable substitution when messages are hoisted and nested.
graphite-app bot
pushed a commit
that referenced
this pull request
Jan 2, 2026
### TL;DR
Fix handling of pound symbols (`#`) in nested plural messages by replacing them with explicit variable references to avoid ambiguity.
### What changed?
- Added a new `replacePoundWithArgument` function that transforms pound elements (`#`) into explicit number elements (`{variableName, number}`) when needed
- Modified the hoisting logic to detect when plural elements are followed by other plural/select elements
- When multiple plurals are present, the outer plural's pound symbols are replaced with explicit variable references
- Implemented the same fix in both TypeScript and Rust versions of the parser
### How to test?
The PR includes test cases that verify the correct behavior:
- Test with two plurals: `{topicCount, plural, one {# topic} other {# topics}} and {noteCount, plural, one {# note} other {# notes}}`
- Test with three plurals: `{a, plural, one {# a} other {# as}}, {b, plural, one {# b} other {# bs}}, and {c, plural, one {# c} other {# cs}}`
### Why make this change?
Fixes issue #4202 where nested plural messages with pound symbols (`#`) could be ambiguous. When multiple plurals are present in a message, the pound symbol in each plural should refer to its own variable. By replacing outer plural's pound symbols with explicit variable references, we ensure correct variable substitution when messages are hoisted and nested.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TL;DR
Fix handling of pound symbols (
#) in nested plural messages by replacing them with explicit variable references to avoid ambiguity.What changed?
replacePoundWithArgumentfunction that transforms pound elements (#) into explicit number elements ({variableName, number}) when neededHow to test?
The PR includes test cases that verify the correct behavior:
{topicCount, plural, one {# topic} other {# topics}} and {noteCount, plural, one {# note} other {# notes}}{a, plural, one {# a} other {# as}}, {b, plural, one {# b} other {# bs}}, and {c, plural, one {# c} other {# cs}}Why make this change?
Fixes issue #4202 where nested plural messages with pound symbols (
#) could be ambiguous. When multiple plurals are present in a message, the pound symbol in each plural should refer to its own variable. By replacing outer plural's pound symbols with explicit variable references, we ensure correct variable substitution when messages are hoisted and nested.