test(@formatjs/intl-displaynames): add more tests for #3387#5777
Closed
test(@formatjs/intl-displaynames): add more tests for #3387#5777
Conversation
Member
Author
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has required the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
Merge activity
|
graphite-app bot
pushed a commit
that referenced
this pull request
Jan 2, 2026
### TL;DR Enhanced test coverage for calendar and dateTimeField types in DisplayNames API. ### What changed? Expanded test coverage for the DisplayNames API, specifically for: 1. Calendar type support: - Added tests for different styles (long, short, narrow) - Added tests for multiple calendar types with actual values - Added tests for calendar codes with hyphens - Added tests for case-insensitive handling - Added tests for invalid calendar code patterns - Added tests for fallback behavior 2. DateTimeField type support: - Added comprehensive tests for all valid dateTimeField codes - Added tests for different styles (long, short, narrow) - Added tests for invalid dateTimeField codes - Added validation tests for all dateTimeField codes from the spec ### How to test? Run the test suite for the intl-displaynames package: ``` cd packages/intl-displaynames npm test ``` ### Why make this change? This change addresses issue #3387 by providing more thorough test coverage for calendar and dateTimeField types in the DisplayNames API. The expanded tests ensure proper handling of different styles, code patterns, case sensitivity, and fallback behaviors, which helps validate the implementation against the ECMA-402 specification.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TL;DR
Enhanced test coverage for calendar and dateTimeField types in DisplayNames API.
What changed?
Expanded test coverage for the DisplayNames API, specifically for:
Calendar type support:
DateTimeField type support:
How to test?
Run the test suite for the intl-displaynames package:
Why make this change?
This change addresses issue #3387 by providing more thorough test coverage for calendar and dateTimeField types in the DisplayNames API. The expanded tests ensure proper handling of different styles, code patterns, case sensitivity, and fallback behaviors, which helps validate the implementation against the ECMA-402 specification.