feat(@formatjs/intl,@formatjs/fast-memoize,@formatjs/icu-messageformat-parser,@formatjs/intl-displaynames,@formatjs/intl-listformat,intl-messageformat,@formatjs/ecma402-abstract,@formatjs/intl-numberformat,@formatjs/icu-skeleton-parser): esm conditional exports#4109
Merged
pyrocat101 merged 1 commit intomainfrom May 22, 2023
Merged
feat(@formatjs/intl,@formatjs/fast-memoize,@formatjs/icu-messageformat-parser,@formatjs/intl-displaynames,@formatjs/intl-listformat,intl-messageformat,@formatjs/ecma402-abstract,@formatjs/intl-numberformat,@formatjs/icu-skeleton-parser): esm conditional exports#4109pyrocat101 merged 1 commit intomainfrom
pyrocat101 merged 1 commit intomainfrom
Conversation
573a58a to
259d9b6
Compare
…t-parser,@formatjs/intl-displaynames,@formatjs/intl-listformat,intl-messageformat,@formatjs/ecma402-abstract,@formatjs/intl-numberformat,@formatjs/icu-skeleton-parser): esm conditional exports
259d9b6 to
8dd002f
Compare
unional
pushed a commit
to unional/formatjs
that referenced
this pull request
Jun 7, 2023
…t-parser,@formatjs/intl-displaynames,@formatjs/intl-listformat,intl-messageformat,@formatjs/ecma402-abstract,@formatjs/intl-numberformat,@formatjs/icu-skeleton-parser): esm conditional exports (formatjs#4109) Fix formatjs#4013 Add `exports` to `@formatjs/intl` and its transitive dependencies to support dual ESM / CJS package distribution. ## Why is this not a breaking change? Anything not exported here never appeared in the documentation and therefore are considered internal implementation of the library. Therefore not exporting them is not a breaking change.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #4013
Add
exportsto@formatjs/intland its transitive dependencies to support dual ESM / CJS package distribution.Why is this not a breaking change?
Anything not exported here never appeared in the documentation and therefore are considered internal implementation of the library. Therefore not exporting them is not a breaking change.